-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: left to right filename sanitization #15388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AndyScherzinger
merged 35 commits into
master
from
fix/left-to-right-filename-sanitization-v2
Aug 23, 2025
Merged
fix: left to right filename sanitization #15388
AndyScherzinger
merged 35 commits into
master
from
fix/left-to-right-filename-sanitization-v2
Aug 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1c48637
to
d0d761a
Compare
daf5295
to
644bb91
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
644bb91
to
980914d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
980914d
to
36986ef
Compare
AndyScherzinger
approved these changes
Aug 20, 2025
f1eb176
to
fd0c067
Compare
AndyScherzinger
approved these changes
Aug 22, 2025
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
8fd357b
to
013caa1
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15388.apk |
Fine by me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The purpose of this PR is not to enhance the UI, but to ensure that the correct filenames are displayed. Certain invisible or special Unicode characters can be used to manipulate a filename’s visual representation, misleading users about its true file extension.
e.g. filename: invoiceexe.docRLO this will appear as invoice.doc, but actual filename is invoicedoc.exe. It is not a doc file, it's an EXE file.
Previously, the filename with extension in one text view component was shown; now, we also display the file extension as a separate text view component next to the filename, which is why the UI is changed.
The reason for using two separate text view elements is explained in detail in the mentioned issue.