Skip to content

[WP #60683][display error if groupfolders app not supported] #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WP #60683][display error if groupfolders app not supported] #787

wants to merge 1 commit into from

Conversation

nabim777
Copy link
Collaborator

@nabim777 nabim777 commented Mar 6, 2025 •
edited
Loading

Description

In this PR, an error message is added which will display if the groupfolders app is not supported with the integration OpenProject.

Related Issue or Workpackage

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@nabim777 nabim777 self-assigned this Mar 6, 2025
@nabim777 nabim777 force-pushed the show-error-groupfolder-unsupported branch 2 times, most recently from 00f8e5f to 087dc14 Compare March 6, 2025 03:46
@nabim777 nabim777 marked this pull request as ready for review March 6, 2025 08:29
@nabim777 nabim777 force-pushed the show-error-groupfolder-unsupported branch from 087dc14 to 2a02b20 Compare March 6, 2025 08:39
@nabim777 nabim777 marked this pull request as draft March 6, 2025 08:47
@nabim777 nabim777 force-pushed the show-error-groupfolder-unsupported branch 2 times, most recently from 75d08be to be5619d Compare March 6, 2025 10:17
@nabim777 nabim777 marked this pull request as ready for review March 6, 2025 10:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

JS Code Coverage

Coverage after merging show-error-groupfolder-unsupported into master will be
89.90%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   fileActions.js0%0%0%0%1, 1, 10–19, 2, 20–23, 3–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50, 6–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js77.27%33.33%50%79.52%12–20, 23–32
src/components
   AdminSettings.vue95.34%92.37%95.65%95.76%1003–1004, 1012, 1023–1025, 1042–1044, 1056, 1056, 1056–1061, 1064–1065, 1069–1070, 1073–1074, 1078–1079, 1089–1094, 1191–1193, 1211–1223, 1238–1241, 1254–1257, 1278–1281, 1394, 1394–1395, 1395–1402, 1412–1413, 1473–1475, 1510–1513, 1549–1551, 1571–1574, 754–755, 861, 993–995
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue85.82%63.64%100%87.39%49–56, 64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormHeading.vue100%100%100%100%
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue96.91%85.71%100%97.67%51–53
src/components/tab
   EmptyContent.vue94.90%75%100%97.06%102–105, 107–111, 97
   SearchInput.vue95.32%92.96%94.74%95.79%139–140, 193, 204–209, 268–270, 286–288, 292–297
   WorkPackage.vue86.25%73.17%93.33%87.62%107–116, 129–131, 142–146, 156–158, 176–182, 220, 220–225, 225, 225–236, 81–82
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100, 11–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
   filesPluginLessThan28.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70, 8–9
src/utils
   workpackageHelper.js89.84%82.14%88.89%92.15%100–102, 156–157, 23–27, 34, 34, 36, 36, 50–52, 54, 54, 54–56, 97–99
src/views
   CreateWorkPackageModal.vue94.41%86.54%91.67%95.58%358–360, 363, 464–467, 472–477, 482–487, 493–496, 499, 515, 515, 556–560, 570–572, 591–593, 622–624, 646–648, 657–661
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.06%92.45%93.33%94.33%100–101, 107–109, 129, 140–141, 175–185, 234–236, 98–99

@nabim777 nabim777 force-pushed the show-error-groupfolder-unsupported branch from be5619d to e356aef Compare March 19, 2025 09:43
@github-actions GitHub Actions
Copy link

PHP Code Coverage

Coverage after merging show-error-groupfolder-unsupported into master will be
61.12%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%24, 31–40
   ExchangedTokenRequestedEventHelper.php0%100%0%0%20, 27–29
   ServerVersionHelper.php0%100%0%0%23–24, 27, 30
server/apps/integration_openproject/lib/AppInfo
   Application.php7.41%100%25%6%100, 102–105, 107, 109, 111, 115–118, 120–131, 133, 136, 140, 144–146, 73–75, 78–82, 84–89, 91–92, 95
server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%28, 30–32, 41–42
server/apps/integration_openproject/lib/Controller
   ConfigController.php70.02%100%55.56%70.62%132, 173–174, 176, 178–180, 182–185, 188–189, 191, 237, 247, 251–253, 356–360, 485–487, 489–491, 540, 628–631, 633–634, 637, 645–649, 660, 674–677, 685, 689–692, 706–710, 712–713, 715–731, 748–753, 755–756, 758–760, 763, 765–781, 794–801, 803–806, 808–812, 821–826
   DirectDownloadController.php0%100%0%0%33–35, 50–52, 54–61
   DirectUploadController.php70.83%100%100%70%124–126, 169–171, 182, 186–189, 191, 201, 208, 224–226, 228–229, 232–237, 240, 242, 250–252, 258–260, 268–270, 285–287, 306, 311, 317
   FilesController.php72.95%100%83.33%72.41%178–179, 241, 246–249, 251, 253–266, 269–270, 272–273, 277–280, 283, 289
   OpenProjectAPIController.php81.19%100%82.35%81.08%116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 75
   OpenProjectController.php96.45%100%80%96.95%241–245
server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108–109, 111–116, 118–122, 126–128, 131–142, 61–66, 73, 80, 87, 94
server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%21
server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php0%100%0%0%30, 38–39, 42–45, 47
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
   BeforeUserDeletedListener.php0%100%0%0%30, 37–38, 40–43, 45
   LoadAdditionalScriptsListener.php0%100%0%0%37–38, 46–47, 49, 51–52, 54–56, 58
   LoadSidebarScript.php0%100%0%0%100, 102–103, 105–106, 108, 110–111, 113, 115, 117–124, 128, 131–136, 70–88, 97–98
   OpenProjectReferenceListener.php0%100%0%0%44–46, 53–54, 56, 58–59, 61–73
   TermsOfServiceEventListener.php0%100%0%0%41–42, 47–48, 50–51, 53–55, 58–62
   UserChangedListener.php0%100%0%0%34, 41–42, 45–50, 53
server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%30, 40–48, 50–58, 60–62, 64
   Version2310Date20230116153411.php0%100%0%0%29, 32–35, 37–62, 64–65, 67
   Version2400Date20230504144300.php0%100%0%0%30, 40–43
   Version2640Date20240628114301.php0%100%0%0%35, 47–49, 52–53, 56
server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%100–103, 105–108, 110–113, 117–118, 120–121, 124–133, 135–139, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%108–112, 114, 63–76, 78–85
   DirectDownloadService.php88.46%100%100%87.50%62–63, 65
   DirectUploadService.php42.86%100%66.67%40%101, 62–65, 67–75, 95
   OauthService.php28%100%40%26.67%100–105, 116–123, 72–80, 82–88, 97–99
   OpenProjectAPIService.php76.25%100%75.76%76.29%1011–1012, 1014, 1016–1017, 1040–1046, 1048–1055, 1057–1064, 1116–1118, 1120–1122, 1125–1129, 1131–1133, 1142–1145, 1148–1150, 1152, 1155–1160, 1164–1165, 1204–1207, 1226–1233, 1249–1250, 1257–1259, 1261–1264

@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@saw-jan saw-jan Awaiting requested review from saw-jan saw-jan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@nabim777 nabim777

Labels
feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nabim777