Skip to content

Localized Download Limit User Interface #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 6.6.7
Choose a base branch
from
Open

Localized Download Limit User Interface #3564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions iOSClient/Share/Advanced/DownloadLimit/NCShareDownloadLimitTableViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ class NCShareDownloadLimitTableViewController: UITableViewController {
NCCapabilities.shared.getCapabilities(account: metadata.account).capabilityFileSharingDownloadLimitDefaultLimit
}

@IBOutlet var allowedDownloadsCell: UITableViewCell!
@IBOutlet var limitDownloadCell: UITableViewCell!
@IBOutlet var limitSwitch: UISwitch!
@IBOutlet var limitTextField: UITextField!

Expand All @@ -47,6 +49,14 @@ class NCShareDownloadLimitTableViewController: UITableViewController {
} else {
limitSwitch.isOn = false
}

var allowedDownloadsCellConfiguration = UIListContentConfiguration.cell()
allowedDownloadsCellConfiguration.text = NSLocalizedString("_share_allowed_downloads_", comment: "")
allowedDownloadsCell.contentConfiguration = allowedDownloadsCellConfiguration

var limitDownloadCellConfiguration = UIListContentConfiguration.cell()
limitDownloadCellConfiguration.text = NSLocalizedString("_share_limit_download_", comment: "")
limitDownloadCell.contentConfiguration = limitDownloadCellConfiguration
}

@IBAction func switchDownloadLimit(_ sender: UISwitch) {
Expand Down
6 changes: 4 additions & 2 deletions iOSClient/Share/NCShare.storyboard
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="23504" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="Ts3-RO-A9l">
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="23727" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="Ts3-RO-A9l">
<device id="retina5_5" orientation="portrait" appearance="light"/>
<dependencies>
<deployment identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="23506"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="23721"/>
<capability name="Image references" minToolsVersion="12.0"/>
<capability name="Safe area layout guides" minToolsVersion="9.0"/>
<capability name="System colors in document resources" minToolsVersion="11.0"/>
Expand Down Expand Up @@ -335,6 +335,8 @@
</connections>
</tableView>
<connections>
<outlet property="allowedDownloadsCell" destination="tvZ-6P-X8V" id="XyE-JY-D4y"/>
<outlet property="limitDownloadCell" destination="Nhk-Fc-G3o" id="OhC-yT-fQp"/>
<outlet property="limitSwitch" destination="nFs-et-CHB" id="VPn-S5-HsB"/>
<outlet property="limitTextField" destination="XQ1-Wz-Q84" id="Wr9-ib-xta"/>
</connections>
Expand Down
Binary file modified iOSClient/Supporting Files/de.lproj/Localizable.strings
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions iOSClient/Supporting Files/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@
"_share_file_drop_" = "File drop (upload only)";
"_share_secure_file_drop_" = "Secure file drop (upload only)";
"_share_hide_download_" = "Hide download";
"_share_allowed_downloads_" = "Allowed downloads";
"_share_limit_download_" = "Limit downloads";
"_remaining_" = "%d remaining";
"_share_password_protect_" = "Password protection";
Expand Down