Skip to content

fix: delete tag modal #10924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: delete tag modal #10924

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1006c0c
Fixes #10101 to button styling
keremsemiz Mar 25, 2025
414c9cb
Update
keremsemiz Mar 27, 2025
a5d735e
Update 2
keremsemiz Mar 27, 2025
fbae13b
Merge branch 'main' into keremsemiz/issue10101
keremsemiz Mar 27, 2025
1b96159
Final update
keremsemiz Mar 27, 2025
85e9120
Merge branch 'keremsemiz/issue10101' of https://github.com/nextcloud/…
keremsemiz Mar 27, 2025
1ba90eb
Update padding plus cancel emitting
keremsemiz Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/components/ConfirmationModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
-->

<template>
<NcModal class="confirm-modal" @close="cancel">
<NcDialog class="confirm-modal" @close="cancel">
<div class="confirm-modal">
<h2>{{ title }}</h2>
<slot />
Expand All @@ -22,19 +22,19 @@
</NcButton>
</div>
</div>
</NcModal>
</NcDialog>
</template>

<script>

import { NcButton, NcModal } from '@nextcloud/vue'
import { NcButton, NcDialog } from '@nextcloud/vue'
import { translate as t } from '@nextcloud/l10n'

export default {
name: 'ConfirmationModal',
components: {
NcButton,
NcModal,
NcDialog,
},
props: {
title: {
Expand All @@ -60,18 +60,23 @@ export default {
},
cancel() {
this.$emit('cancel')
this.$emit('close')
},
},
}
</script>

<style lang="scss" scoped>
.confirm-modal {
padding: 20px;

padding: 0 20px 20px 20px;
&__buttons {
display: flex;
justify-content: space-between;
margin-top: 30px;
}
}
:deep(.dialog__name){
display: none;
}
Comment on lines +78 to +80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be problematic for a11y?


</style>
Loading