Skip to content

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jul 2, 2025

fix #11355
fix #11353

b plain/text html
image image image

@hamza221 hamza221 self-assigned this Jul 2, 2025
@hamza221 hamza221 added bug 3. to review design: review 🔍 Bugs and features identified in design review calls labels Jul 2, 2025
@ChristophWurst
Copy link
Member

Edge case: emails to yourself now show some "void" underneath the thread heading:
image

I'm undecided if we should add special handling or make the header height responsive and smaller in that case

@ChristophWurst
Copy link
Member

Bildschirmfoto vom 2025-07-02 18-37-36
Bildschirmfoto vom 2025-07-02 18-37-14
image

I think the message header (sender + email) should be our reference. Thread header has to move left a few px. Plain text emails as well. The white box of HTML emails should start at the same virtual line.

@hamza221
Copy link
Contributor Author

hamza221 commented Jul 2, 2025

Edge case: emails to yourself now show some "void" underneath the thread heading: image

I'm undecided if we should add special handling or make the header height responsive and smaller in that case

I faced the same edge case, @nimishavijay what do you think ?

@hamza221
Copy link
Contributor Author

hamza221 commented Jul 2, 2025

I'll merge #11354 here because we also want the buttons to align

@hamza221 hamza221 linked an issue Jul 2, 2025 that may be closed by this pull request
2 tasks
@ChristophWurst
Copy link
Member

Please resolve the conflicts

@ChristophWurst
Copy link
Member

/backport to stable5.2

@GretaD
Copy link
Contributor

GretaD commented Aug 15, 2025

@hamza221 should i take over this? I have the time. I can also take over the other ones you have started as part of the desgn review we had :)

@hamza221
Copy link
Contributor Author

@hamza221 should i take over this? I have the time. I can also take over the other ones you have started as part of the desgn review we had :)

Sure yes, thank you.

@GretaD GretaD self-assigned this Aug 15, 2025
@GretaD GretaD force-pushed the fix/thread-heading branch from fed5374 to e70180e Compare August 15, 2025 13:13
@GretaD GretaD force-pushed the fix/thread-heading branch 4 times, most recently from 744948c to 1512366 Compare August 21, 2025 10:14
@GretaD GretaD force-pushed the fix/thread-heading branch from 1512366 to 989f540 Compare August 21, 2025 10:18
@hamza221 hamza221 merged commit 096c97f into main Aug 21, 2025
38 checks passed
@hamza221 hamza221 deleted the fix/thread-heading branch August 21, 2025 10:55
@ChristophWurst
Copy link
Member

/backport to stable5.3

@ChristophWurst
Copy link
Member

/backport to stable5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug design: review 🔍 Bugs and features identified in design review calls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread heading AI responses and reply button
3 participants