Skip to content

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Aug 25, 2025

ref #11328

smart reply:
Screenshot from 2025-09-01 18-40-23

thread summary:
Screenshot from 2025-09-02 17-08-38

Envelope summary:
Screenshot from 2025-09-02 16-38-05

@GretaD GretaD requested a review from nimishavijay August 25, 2025 13:53
@GretaD GretaD self-assigned this Aug 25, 2025
@GretaD GretaD requested a review from ChristophWurst as a code owner August 25, 2025 13:54
@GretaD GretaD requested a review from kesselb as a code owner August 25, 2025 13:54
@GretaD GretaD mentioned this pull request Aug 25, 2025
24 tasks
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout changes look great! Only change for now is to use the filled version of the assistant icon :)

@GretaD GretaD marked this pull request as draft August 25, 2025 15:03
@GretaD GretaD requested a review from nimishavijay August 27, 2025 07:13
@GretaD GretaD marked this pull request as ready for review August 27, 2025 07:13
@nimishavijay
Copy link
Member

nimishavijay commented Aug 27, 2025

Looks really nice! Couple of points:

  • we decided that the assistant components should have tertiary buttons unless it's generating something using AI, so we can change the "Go to latest message" button to a tertiary-no-background button

  • forgot to mention in the original issue, but in dark mode we should use the following colours:
    Dark mode:
    Background: #221D2B
    border: linear-gradient(125deg, #0C3A65 50%, #6204A5 125%)

  • nothing to change for now but just a heads up that we will adopt color variables for the assistant elements to be consistent across different apps so once they are in we can do a follow up to use the variables instead of gradient values (ref Add variables for Assistant colours server#54665)

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newest screenshot looks really nice! only 3 small notes:

  • I see that in the German screenshot the "Summary is AI generated" notice is still in english, it should also be translated to whatever language
  • The strings seem to wrap and ellipsize a lot because they're all too long in German :( Maybe we could do "Newest message" instead of "Go to newest message"?
  • The assistant variables are available now just as an FYI nextcloud/server#54679 they should be used as much as possible in case they are changed later on closer to the release.

@GretaD
Copy link
Contributor Author

GretaD commented Aug 29, 2025

I see that in the German screenshot the "Summary is AI generated" notice is still in english, it should also be translated to whatever language

thats because its on my local env, and its not pushed yet to transifex :)

@GretaD GretaD force-pushed the feat/new-thread-summary-design branch from c4cede6 to 39faf01 Compare September 1, 2025 17:10
@GretaD GretaD marked this pull request as draft September 2, 2025 14:16
@GretaD GretaD requested a review from nimishavijay September 2, 2025 15:15
@GretaD GretaD marked this pull request as ready for review September 2, 2025 15:15
@ChristophWurst
Copy link
Member

@GretaD are the three items of #11575 (review) done?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

img/creation-gradient.svg seems unused?

@GretaD
Copy link
Contributor Author

GretaD commented Sep 2, 2025

@GretaD are the three items of #11575 (review) done?

yes, the first point is not relevant. The other 2 are done

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Only 2 small changes:

  • In the thread summary, the assistant icon should be center aligned with the avatar in the messages below (seems like it's a bit to the right in the screenshot)
  • In the AI replies, we can remove the icon (the gradient outline is already very eye catching) and make the text color --main-text (I'm concerned about a11y of the gradient on unbolded text)

Other than that it's good to to! Approving to not block :)

@GretaD
Copy link
Contributor Author

GretaD commented Sep 3, 2025

  • In the AI replies, we can remove the icon (the gradient outline is already very eye catching) and make the text color --main-text (I'm concerned about a11y of the gradient on unbolded text)

I can change the colour of the text, but removing the icon means changing the component that we just created for the assistantbuttons: https://nextcloud-vue-components.netlify.app/#/Components/Nextcloud%20Assistant?id=ncassistantbutton

I mean, i can remove it just for mail with :deep(), but that means that the assistant buttons will be different in different part of the software.

@nimishavijay
Copy link
Member

but removing the icon means changing the component that we just created for the assistantbuttons

Oh hmm, in that case pinging @marcoambrosini to double check the usage of the button

@marcoambrosini
Copy link
Member

I think it is fine to use Text only buttons too

@GretaD
Copy link
Contributor Author

GretaD commented Sep 3, 2025

comment from Marco: Nimisha might be out for today, so I'd suggest to keep it as you have it for now and then we can always hack with a quick pr, or update the components to create more variants

@GretaD GretaD force-pushed the feat/new-thread-summary-design branch from 66936f5 to 5a6674b Compare September 3, 2025 13:16
@GretaD
Copy link
Contributor Author

GretaD commented Sep 3, 2025

Screenshot from 2025-09-03 15-14-42

@GretaD GretaD requested a review from st3iny September 3, 2025 13:17
@GretaD GretaD force-pushed the feat/new-thread-summary-design branch from 5a6674b to 997c19e Compare September 3, 2025 13:44
@GretaD GretaD merged commit fe3fa73 into main Sep 3, 2025
38 checks passed
@GretaD GretaD deleted the feat/new-thread-summary-design branch September 3, 2025 14:28
@ChristophWurst
Copy link
Member

/backport to stable5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants