Skip to content

Conversation

@elchukc
Copy link

@elchukc elchukc commented May 26, 2025

Summary

Removes 4 out of 5 uses of jquery-ui highlighted in #12980. The last one was a tooltip that was deleted in PR#37244.

I did my best to remove all jquery-ui uses in user_ldap/ but jquery is unfamiliar to me and it's hard to tell if I'm missing anything.

After a bunch of digging around in the documentation, I still cannot get any of the automated tests or php linting to work, although did run npm run lint:fix

TODO

  • move global jquery-ui into file handling modules

Checklist

@elchukc elchukc requested review from a team as code owners May 26, 2025 04:28
@elchukc elchukc requested review from leftybournes, nfebe, skjnldsv and szaimen and removed request for a team May 26, 2025 04:28
@elchukc elchukc force-pushed the drop_jqery_multiselect_widget branch from 6184d57 to 403462e Compare May 26, 2025 04:31
@szaimen szaimen removed their request for review May 26, 2025 08:36
@szaimen szaimen added this to the Nextcloud 32 milestone May 26, 2025
@elchukc elchukc changed the title Drop unused jqery multiselect widget Drop unused jquery multiselect widget May 27, 2025
@elchukc elchukc marked this pull request as draft May 31, 2025 17:35
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move away from jquery-ui

3 participants