fix(federation): remove background jobs when removing trusted servers #53760
+152
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
bug/noid/federation-background-job-same-url-different-token
branch
from
1e448cd to
6465f42
Compare
Add event listener to remove matching background jobs for trusted server url. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bug/noid/federation-background-job-same-url-different-token
branch
from
6465f42 to
af8e175
Compare
kesselb
requested review from
ArtificialOwl,
artonge and
provokateurin
and removed request for
a team
kesselb
added
3. to review
|
Btw while on it, when another server adds your server as trusted, they run this background job all the time, but as a "recipient" you don't see that someone is asking to get added as a trusted server, neither can you deny it, so the other server gives up, right? |
Yes |
…servers Signed-off-by: Daniel Kesselberg <[email protected]>
iterator_to_array on PHP 8.1 does not accept an array and fails hard with a type error Signed-off-by: Daniel Kesselberg <[email protected]>
nickvergessen
approved these changes
Jul 3, 2025
apps/federation/tests/Listener/TrustedServerRemovedListenerTest.php
Outdated
Show resolved
Hide resolved
…servers Signed-off-by: Daniel Kesselberg <[email protected]>
…l-different-token
nickvergessen
approved these changes
Jul 4, 2025
|
I can't dive into this in the next few days, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add event listener to remove matching background jobs for trusted server url.
Motivation: When debugging federation locally, I occasionally remove and re-add the server. This can result in multiple background jobs for the same url/target, but with different tokens. I've encountered this issue several times. Therefore, I added an event listener to remove them immediately. I won't backport this change as it has minimal impact on production systems (since those jobs will expire eventually), and it primarily improves the developer experience.
Checklist