Skip to content

Conversation

@edward-ly
Copy link
Contributor

Summary

Before After
Screenshot 2025-07-02 at 16-00-45 All files - Nextcloud Screenshot 2025-07-02 at 15-58-11 All files - Nextcloud

Checklist

@edward-ly
Copy link
Contributor Author

/compile

@edward-ly edward-ly marked this pull request as ready for review July 2, 2025 23:29
@edward-ly edward-ly requested review from a team as code owners July 2, 2025 23:29
@edward-ly edward-ly requested review from nfebe, skjnldsv and susnux and removed request for a team July 2, 2025 23:29
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all the renaming? It was done on purpose to group all icons by name (IconXY).

@skjnldsv

This comment was marked as resolved.

@edward-ly edward-ly added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: comments javascript labels Jul 3, 2025
@edward-ly edward-ly added this to the Nextcloud 32 milestone Jul 3, 2025
@edward-ly
Copy link
Contributor Author

Why all the renaming? It was done on purpose to group all icons by name (IconXY).

I thought "IconXY" was a mistake at first, as our team names the icons as "XYIcon" instead, but it seems that's not the case. And now that I see all the icon names with git grep vue-material-design-icons, there's an eclectic mix of both, so I'm not sure which is right anymore.

@skjnldsv
Copy link
Member

skjnldsv commented Jul 3, 2025

so I'm not sure which is right anymore.

I agree with @susnux , IconXxxx is the preferred way, similar than the NcXxxx Components

@edward-ly edward-ly force-pushed the fix/comments-outlined-icons branch from 26075a8 to cebb1eb Compare July 3, 2025 16:54
@edward-ly
Copy link
Contributor Author

I agree with @susnux , IconXxxx is the preferred way, similar than the NcXxxx Components

OK, I renamed all the icons in the comments app to IconX in that case.

@edward-ly edward-ly force-pushed the fix/comments-outlined-icons branch from cebb1eb to 3ecf3fb Compare July 3, 2025 16:56
@skjnldsv
Copy link
Member

skjnldsv commented Jul 4, 2025

Thanks @edward-ly !!

@susnux susnux force-pushed the fix/comments-outlined-icons branch from 3ecf3fb to 6aaa853 Compare July 4, 2025 16:09
@susnux
Copy link
Contributor

susnux commented Jul 4, 2025

/compile

Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv merged commit 224479a into master Jul 4, 2025
124 checks passed
@skjnldsv skjnldsv deleted the fix/comments-outlined-icons branch July 4, 2025 19:18
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feature: comments javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants