-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(comments): switch to outlined icons where possible #53776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/compile |
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all the renaming? It was done on purpose to group all icons by name (IconXY).
This comment was marked as resolved.
This comment was marked as resolved.
I thought "IconXY" was a mistake at first, as our team names the icons as "XYIcon" instead, but it seems that's not the case. And now that I see all the icon names with |
I agree with @susnux , IconXxxx is the preferred way, similar than the |
26075a8 to
cebb1eb
Compare
OK, I renamed all the icons in the comments app to IconX in that case. |
cebb1eb to
3ecf3fb
Compare
|
Thanks @edward-ly !! |
Signed-off-by: Edward Ly <[email protected]>
3ecf3fb to
6aaa853
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Summary
Checklist