fix(ocm): align discovery process with OCM spec #55648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickenordin
requested review from
ArtificialOwl,
provokateurin and
salmart-dev
and removed request for
a team
mickenordin
force-pushed
the
fix/ocm-discovery-spec-compliant
branch
3 times, most recently
from
4b7b3e5 to
810a289
Compare
provokateurin
requested changes
Oct 9, 2025
mickenordin
force-pushed
the
fix/ocm-discovery-spec-compliant
branch
from
810a289 to
97eb0e9
Compare
provokateurin
approved these changes
Oct 9, 2025
ArtificialOwl
approved these changes
Oct 10, 2025
mickenordin
force-pushed
the
fix/ocm-discovery-spec-compliant
branch
from
375ca5a to
e68a63c
Compare
|
/backport to stable32 |
mickenordin
added
4. to release
mickenordin
force-pushed
the
fix/ocm-discovery-spec-compliant
branch
3 times, most recently
from
40efebc to
1aa8fc3
Compare
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Oct 17, 2025
Signed-off-by: Joas Schilling <[email protected]>
|
mickenordin
force-pushed
the
fix/ocm-discovery-spec-compliant
branch
from
1aa8fc3 to
b0a33a0
Compare
mickenordin
force-pushed
the
fix/ocm-discovery-spec-compliant
branch
from
2d4218f to
018966d
Compare
mickenordin
force-pushed
the
fix/ocm-discovery-spec-compliant
branch
from
018966d to
ee7ac62
Compare
- Attempt discovery at both /.well-known/ocm and /ocm-provider as defined in draft-lopresti-open-cloud-mesh-06 §5.2. - Maintains compatibility with existing /ocm-provider behavior. Signed-off-by: Micke Nordin <[email protected]>
Co-authored-by: Kate <[email protected]> Signed-off-by: Micke Nordin <[email protected]>
- Prevent undefined variable access when response is missing. Signed-off-by: Micke Nordin <[email protected]>
If we still have an exception at the last iteration of the loop we throw it. Signed-off-by: Micke Nordin <[email protected]>
mickenordin
force-pushed
the
fix/ocm-discovery-spec-compliant
branch
from
ee7ac62 to
a582db8
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this discovery fails with ownCloud oCIS