- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 4.6k
 
fix(ocm-sharing): The owner needs to be set for sharing to work #55827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           /backport to stable32  | 
    
        
          
                apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php
              
                Outdated
          
            Show resolved
            Hide resolved
        
      8030a9d    to
    7335dd0      
    Compare
  
    7335dd0    to
    8cf1753      
    Compare
  
    8cf1753    to
    6b07b1a      
    Compare
  
    The specification says that the display name is optional and can thus be empty, and in fact it is from oCIS and CERNBox shares. The correct thing to set is the required opaque id from the remote provider, the `owner` which will allways be there. Signed-off-by: Micke Nordin <[email protected]>
6b07b1a    to
    f7dcd1d      
    Compare
  
    | 
           /backport to stable32  | 
    
| 
           Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.)  | 
    
The specification says that the display name is optional and can thus be empty, and in fact it is from oCIS and CERNBox shares.
The correct thing to set is the required opaque id from the remote provider, the
ownerwhich will always be there.Moved here from #55752