Skip to content

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented May 7, 2025

requires PR improveCallGrid

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi added 24 commits May 7, 2025 17:24
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
For now, instead to measure height mixed from xml and compose, assume a fixed height for the xml views (callInfosLinearLayout and callControls) to limit the grid height.
They is not a nice solution and should be replaced once everything is migrated to compose.

Signed-off-by: Marcel Hibbe <[email protected]>
improve pip handling a bit

minor changes

Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
at least as another cell. fullscreen needs to be implemented

Signed-off-by: Marcel Hibbe <[email protected]>
at least as another cell. fullscreen needs to be implemented

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi self-assigned this May 7, 2025
Copy link
Contributor

github-actions bot commented May 7, 2025

Codacy

Lint

TypemasterPR
Warnings99100
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness22216
Dodgy code7167
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310100

Lint increased!

Copy link
Contributor

github-actions bot commented May 7, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4949-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant