Preserve Conversation List position

[rapterjet2004]

• fixes Jump to the top after press back button #5041

Conversation List jumps to position of clicked conversation item when back pressed

ToDO

• get/store position in shared preferences, not sure why I sent this by intent. Maybe I need some coffee.
• Reevaluate scroll logic.

I couldn't find a reliable way to save/restore the vertical offset from the calculateVerticalOffset() method. The units don't translate reliably to the ones needed for scrollY and the method to scrollVerticallyBy() requires RecyclerView.State which is internal. Restoring the recycler view state from layoutManager.onSaveInstanceState() also doesn't work.

Current Implementation is quite simple though, requires keeping a reference to the item's viewHolder in ConversationItem. It's then gets the position of the first visible item and calculates the non visible offset to scroll by. The result is the exact position the user left off. Restored/Retrieved from AppPreferences.

🖼️ Screenshots

Screen_recording_20250609_124059.webm

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

This will always place the last opened conversation at the top when coming back. This is not expected but people expect the exact scroll position as when the chat was opened.

It should be solved with
scrollToPositionWithOffset
which gets the scroll position and the offset from when the chat was opened.

[mahibi]

I have the feeling this can be solved in a simpler way.

Right now the position is passed to ChatActivity and back to ConversationList. This should not be necessary at all but ConversationList should handle this itself.
For example this does not work when the app just goes to background and coming back.

Also, i guess that findFirstVisibleItemPosition is something that should not be necessary. It will "just" scroll to an item instead to the exact position.

Can you have a look if there are simpler ways to achieve this?
Like just using the scroll position on the recyclerview itself and just using lifecycle methods to save/restore the scroll postion, eg. from the viewmodel..?

[mahibi]

@rapterjet2004 whats the state for this PR? should it be "to review"?

[mahibi]

not the nicest solution but fine for me as the handling will be replaced with Compose anyway

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5049-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	97	96
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	16	16
Dodgy code	61	61
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	94	94