-
-
Notifications
You must be signed in to change notification settings - Fork 270
Login flow v2 #5100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login flow v2 #5100
Conversation
67fff13
to
18a42aa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
b342b9f
to
a89d9af
Compare
The SSLHandshakeException seems to be solved and i was able to login as expected on sermo 👍 However, i was only able to do this a few times. When clicking on the login button on the webpage, i don't see any form to enter credentials and the app keeps waiting for the website. See video: Screen_recording_20250709_094547.mp4But this also happens for the nextcloud files app! (fyi @alperozturk96 ) So it's maybe some bug / behavior on server side. These are the logs:
Whenever i return to the app (and see it's in the "Please continue the login process in the browser" state), then this is logged:
Not sure yet if this is "solved" by just waiting 20minutes. But this wouldn't be a solution. Some more things:
Maybe @nickvergessen or @alperozturk96 have some insights (for server side or if there were similar topics on android files)? |
It works fine with chrome! Before i had Firefox where it failed!
See: https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Errors/Unexpected_type |
The firefox problem (also discussed in https://cloud.nextcloud.com/call/dxbbx4jy#message_4154968) is now solved for me by reinstalling firefox 🤷♂️ So to sum up: Something to keep in mind if it happens again, but i guess i won't be able to reproduce it now. |
renamed WebViewLoginActivity.kt to BrowserLoginActivity.kt Signed-off-by: rapterjet2004 <[email protected]>
d2c8f8a
to
dad5f17
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5100-talk.apk |
🖼️ Screenshots
login-v2.webm
🚧 TODO
🏁 Checklist
/backport to stable-xx.x