Skip to content

Login flow v2 #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Login flow v2 #5100

merged 1 commit into from
Jul 10, 2025

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jun 30, 2025

🖼️ Screenshots

login-v2.webm

🚧 TODO

  • Got it working
  • Add Cancel button
  • Remove old approach
  • Test if I can add multiple accounts on same instance.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Jun 30, 2025
@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Jun 30, 2025
@rapterjet2004 rapterjet2004 force-pushed the issue-4711-login-flow-v2 branch from 67fff13 to 18a42aa Compare July 2, 2025 13:46
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 2, 2025
@rapterjet2004 rapterjet2004 requested a review from mahibi July 2, 2025 14:13
@rapterjet2004 rapterjet2004 marked this pull request as ready for review July 2, 2025 14:13
mahibi

This comment was marked as resolved.

@mahibi mahibi mentioned this pull request Jul 7, 2025
@mahibi

This comment was marked as resolved.

@mahibi

This comment was marked as resolved.

@rapterjet2004 rapterjet2004 force-pushed the issue-4711-login-flow-v2 branch 2 times, most recently from b342b9f to a89d9af Compare July 8, 2025 14:53
@rapterjet2004 rapterjet2004 requested a review from mahibi July 8, 2025 15:44
@mahibi
Copy link
Collaborator

mahibi commented Jul 9, 2025

The SSLHandshakeException seems to be solved and i was able to login as expected on sermo 👍

However, i was only able to do this a few times.
Now, i am not able to login anymore. There were a few different unexpected things:

When clicking on the login button on the webpage, i don't see any form to enter credentials and the app keeps waiting for the website. See video:

Screen_recording_20250709_094547.mp4

But this also happens for the nextcloud files app! (fyi @alperozturk96 ) So it's maybe some bug / behavior on server side.

These are the logs:

2025-07-09 09:56:24.168 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  --> GET https://sermo.nextcloud.com/status.php
2025-07-09 09:56:24.168 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  User-Agent: Mozilla/5.0 (Android) Nextcloud-Talk v22.0.0 Alpha 09
2025-07-09 09:56:24.168 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  Accept: application/json
2025-07-09 09:56:24.168 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  OCS-APIRequest: true
2025-07-09 09:56:24.168 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  ngrok-skip-browser-warning: true
2025-07-09 09:56:24.168 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  --> END GET
2025-07-09 09:56:24.190 17936-19638 TrafficStats            com.nextcloud.talk2                  D  tagSocket(199) with statsTag=0xffffffff, statsUid=-1
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  <-- 200 https://sermo.nextcloud.com/status.php (208ms)
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  server: nginx
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  date: Wed, 09 Jul 2025 07:56:22 GMT
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  content-type: application/json
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  vary: Accept-Encoding
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  content-security-policy: default-src 'self'; script-src 'self' 'nonce-qWPR2aP6lwu0Tpj3JmvPFQtPZNB9ox4wHD7eUl6ns18='; style-src 'self' 'unsafe-inline'; frame-src *; img-src * data: blob:; font-src 'self' data:; media-src *; connect-src *; object-src 'none'; base-uri 'self';
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  access-control-allow-origin: *
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  strict-transport-security: max-age=15768000; includeSubDomains; preload
2025-07-09 09:56:24.377 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  referrer-policy: no-referrer
2025-07-09 09:56:24.378 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-content-type-options: nosniff
2025-07-09 09:56:24.378 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-frame-options: SAMEORIGIN
2025-07-09 09:56:24.378 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-permitted-cross-domain-policies: none
2025-07-09 09:56:24.378 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-robots-tag: noindex, nofollow
2025-07-09 09:56:24.378 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-xss-protection: 1; mode=block
2025-07-09 09:56:24.380 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  {"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"32.0.0.1","versionstring":"32.0.0 dev","edition":"","productname":"Nextcloud","extendedSupport":false}
2025-07-09 09:56:24.380 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  <-- END HTTP (174-byte body)
2025-07-09 09:56:24.384 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  --> GET https://sermo.nextcloud.com/ocs/v2.php/cloud/capabilities
2025-07-09 09:56:24.385 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  User-Agent: Mozilla/5.0 (Android) Nextcloud-Talk v22.0.0 Alpha 09
2025-07-09 09:56:24.385 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  Accept: application/json
2025-07-09 09:56:24.385 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  OCS-APIRequest: true
2025-07-09 09:56:24.385 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  ngrok-skip-browser-warning: true
2025-07-09 09:56:24.385 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  --> END GET
2025-07-09 09:56:24.546 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  <-- 200 https://sermo.nextcloud.com/ocs/v2.php/cloud/capabilities (161ms)
2025-07-09 09:56:24.546 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  server: nginx
2025-07-09 09:56:24.546 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  date: Wed, 09 Jul 2025 07:56:22 GMT
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  content-type: application/json; charset=utf-8
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-request-id: VzoDuabJCrqm4TJSDYqg
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  cache-control: no-cache, no-store, must-revalidate
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  content-security-policy: default-src 'none';base-uri 'none';manifest-src 'self';frame-ancestors 'none'
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  feature-policy: autoplay 'none';camera 'none';fullscreen 'none';geolocation 'none';microphone 'none';payment 'none'
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-robots-tag: noindex, nofollow
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  etag: "d12a4d38e89ae0d6972da2fa30fa4c6d"
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  strict-transport-security: max-age=15768000; includeSubDomains; preload
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  referrer-policy: no-referrer
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-content-type-options: nosniff
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-frame-options: SAMEORIGIN
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-permitted-cross-domain-policies: none
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-robots-tag: noindex, nofollow
2025-07-09 09:56:24.547 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  x-xss-protection: 1; mode=block
2025-07-09 09:56:24.548 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  {"ocs":{"meta":{"status":"ok","statuscode":200,"message":"OK"},"data":{"version":{"major":32,"minor":0,"micro":0,"string":"32.0.0 dev","edition":"","extendedSupport":false},"capabilities":{"bruteforce":{"delay":0,"allow-listed":false},"integration_openai":{"uses_openai":false},"spreed":{"features":["audio","video","chat-v2","conversation-v4","guest-signaling","empty-group-room","guest-display-names","multi-room-users","favorites","last-room-activity","no-ping","system-messages","delete-messages","mention-flag","in-call-flags","conversation-call-flags","notification-levels","invite-groups-and-mails","locked-one-to-one-rooms","read-only-rooms","listable-rooms","chat-read-marker","chat-unread","webinary-lobby","start-call-flag","chat-replies","circles-support","force-mute","sip-support","sip-support-nopin","chat-read-status","phonebook-search","raise-hand","room-description","rich-object-sharing","temp-user-avatar-api","geo-location-sharing","voice-message-sharing","signaling-v3","publishing-permissions","clear-history","direct-mention-flag","notification-calls","conversation-permissions","rich-object-list-media","rich-object-delete","unified-search","chat-permission","silent-send","silent-call","send-call-notification","talk-polls","breakout-rooms-v1","recording-v1","avatar","chat-get-context","single-conversation-status","chat-keep-notifications","typing-privacy","remind-me-later","bots-v1","markdown-messages","media-caption","session-state","note-to-self","recording-consent","sip-support-dialout","delete-messages-unlimited","edit-messages","silent-send-state","chat-read-last","federation-v1","federation-v2","ban-v1","chat-reference-id","mention-permissions","edit-messages-note-to-self","archived-conversations-v2","talk-polls-drafts","download-call-participants","email-csv-import","conversation-creation-password","call-notification-state-api","schedule-meeting","edit-draft-poll","conversation-creation-all","important-conversations","unbind-conversation","sip-direct-dialin","dashboard-event-rooms","mutual-calendar-events","upcoming-reminders","sensitive-conversations","message-expiration","reactions","chat-summary-api","call-end-to-end-encryption"],"features-local":["favorites","chat-read-status","listable-rooms","phonebook-search","temp-user-avatar-api","unified-search","avatar","remind-me-later","note-to-self","archived-conversations-v2","chat-summary-api","call-notification-state-api","schedule-meeting","conversation-creation-all","important-conversations","sip-direct-dialin","dashboard-event-rooms","mutual-calendar-events","upcoming-reminders"],"config":{"attachments":{"allowed":false},"call":{"enabled":true,"breakout-rooms":true,"recording":true,"recording-consent":2,"supported-reactions":["\u2764\ufe0f","\ud83c\udf89","\ud83d\udc4f","\ud83d\udc4b","\ud83d\udc4d","\ud83d\udc4e","\ud83d\udd25","\ud83d\ude02","\ud83e\udd29","\ud83e\udd14","\ud83d\ude32","\ud83d\ude25"],"can-upload-background":false,"sip-enabled":true,"sip-dialout-enabled":false,"can-enable-sip":false,"start-without-media":false,"max-duration":0,"blur-virtual-background":false,"end-to-end-encryption":false,"predefined-backgrounds":["1_office.jpg","2_home.jpg","3_abstract.jpg","4_beach.jpg","5_park.jpg","6_theater.jpg","7_library.jpg","8_space_station.jpg"],"predefined-backgrounds-v2":["\/apps\/spreed\/img\/backgrounds\/1_office.jpg","\/apps\/spreed\/img\/backgrounds\/2_home.jpg","\/apps\/spreed\/img\/backgrounds\/3_abstract.jpg","\/apps\/spreed\/img\/backgrounds\/4_beach.jpg","\/apps\/spreed\/img\/backgrounds\/5_park.jpg","\/apps\/spreed\/img\/backgrounds\/6_theater.jpg","\/apps\/spreed\/img\/backgrounds\/7_library.jpg","\/apps\/spreed\/img\/backgrounds\/8_space_station.jpg"]},"chat":{"max-length":32000,"read-privacy":0,"has-translation-providers":true,"has-translation-task-providers":true,"typing-privacy":0,"summary-threshold":100},"conversations":{"can-create":false,"force-passwords":false,"list-style":"two-lines","description-length":2000,"retention-event":
2025-07-09 09:56:24.548 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  28,"retention-phone":7,"retention-instant-meetings":1},"federation":{"enabled":false,"incoming-enabled":false,"outgoing-enabled":false,"only-trusted-servers":true},"previews":{"max-gif-size":3145728},"signaling":{"session-ping-limit":200,"hello-v2-token-key":"-----BEGIN PUBLIC KEY-----\nMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAECmFkq8wzd3ucPd7PsvarpqAdycc6\nHs6gHGqrlvXAScCgEk7edZW2ibDAvonTCBKGEMf\/3wHn7spbXoT0egVz+w==\n-----END PUBLIC KEY-----\n"},"experiments":{"enabled":0}},"config-local":{"attachments":["allowed","folder"],"call":["predefined-backgrounds","predefined-backgrounds-v2","can-upload-background","start-without-media","blur-virtual-background"],"chat":["read-privacy","has-translation-providers","has-translation-task-providers","typing-privacy","summary-threshold"],"conversations":["can-create","list-style","description-length","retention-event","retention-phone","retention-instant-meetings"],"federation":["enabled","incoming-enabled","outgoing-enabled","only-trusted-servers"],"previews":["max-gif-size"],"signaling":["session-ping-limit","hello-v2-token-key"],"experiments":["enabled"]},"version":"22.0.0-dev.9"},"theming":{"name":"Sermo","productName":"Nextcloud","url":"https:\/\/sermo.nextcloud.com","slogan":"Nextcloud Talk Test Instance","color":"#00679e","color-text":"#ffffff","color-element":"#00679e","color-element-bright":"#00679e","color-element-dark":"#00679e","logo":"https:\/\/sermo.nextcloud.com\/apps\/theming\/image\/logo?useSvg=1&v=2486","background":"#00679e","background-text":"#ffffff","background-plain":true,"background-default":true,"logoheader":"https:\/\/sermo.nextcloud.com\/apps\/theming\/image\/logo?useSvg=1&v=2486","favicon":"https:\/\/sermo.nextcloud.com\/apps\/theming\/image\/logo?useSvg=1&v=2486"}}}}}
2025-07-09 09:56:24.548 17936-19638 okhttp.OkHttpClient     com.nextcloud.talk2                  I  <-- END HTTP (5759-byte body)
2025-07-09 09:56:24.752 17936-17936 WindowOnBackDispatcher  com.nextcloud.talk2                  W  OnBackInvokedCallback is not enabled for the application.
                                                                                                    Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
2025-07-09 09:56:24.756 17936-17967 TrafficStats            com.nextcloud.talk2                  D  tagSocket(240) with statsTag=0xffffffff, statsUid=-1
2025-07-09 09:56:25.235 17936-17936 RemoteInpu...ectionImpl com.nextcloud.talk2                  W  requestCursorUpdates on inactive InputConnection
2025-07-09 09:56:25.236 17936-17936 InsetsController        com.nextcloud.talk2                  D  hide(ime(), fromIme=true)
2025-07-09 09:56:25.305 17936-17936 ImeTracker              com.nextcloud.talk2                  I  com.nextcloud.talk2:dbe93b32: onCancelled at PHASE_CLIENT_ANIMATION_CANCEL
2025-07-09 09:56:25.307 17936-17936 ImeTracker              com.nextcloud.talk2                  I  com.nextcloud.talk2:a39d2ae2: onRequestHide at ORIGIN_CLIENT reason HIDE_SOFT_INPUT_ON_ANIMATION_STATE_CHANGED fromUser false
2025-07-09 09:56:25.308 17936-17936 ImeTracker              com.nextcloud.talk2                  I  com.nextcloud.talk2:a39d2ae2: onFailed at PHASE_CLIENT_VIEW_SERVED
2025-07-09 09:56:25.564 17936-17975 Surface                 com.nextcloud.talk2                  D  Surface::disconnect
2025-07-09 09:56:25.565 17936-17975 BufferQueueProducer     com.nextcloud.talk2                  D  [com.nextcloud.talk2/com.nextcloud.talk.account.ServerSelectionActivity#21085(BLAST Consumer)pid:17936](id:46100000000c,api:1,p:17936,c:17936) disconnect: api 1
2025-07-09 09:56:26.055 17936-17936 VRI[Browse...nActivity] com.nextcloud.talk2                  D  visibilityChanged oldVisibility=true newVisibility=false
2025-07-09 09:56:26.080 17936-17975 Surface                 com.nextcloud.talk2                  D  Surface::disconnect
2025-07-09 09:56:26.080 17936-17975 BufferQueueProducer     com.nextcloud.talk2                  D  [com.nextcloud.talk2/com.nextcloud.talk.account.BrowserLoginActivity#21109(BLAST Consumer)pid:17936](id:46100000000d,api:1,p:17936,c:17936) disconnect: api 1
2025-07-09 09:56:32.763 17936-18592 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.net.UnknownHostException: Unable to resolve host "sermo.nextcloud.com": No address associated with hostname
2025-07-09 09:56:32.764 17936-19506 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.net.UnknownHostException: Unable to resolve host "sermo.nextcloud.com": No address associated with hostname
2025-07-09 09:56:32.817 17936-18592 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.net.UnknownHostException: Unable to resolve host "sermo.nextcloud.com": No address associated with hostname

Whenever i return to the app (and see it's in the "Please continue the login process in the browser" state), then this is logged:

2025-07-09 09:57:02.830 17936-18592 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.net.UnknownHostException: Unable to resolve host "sermo.nextcloud.com": No address associated with hostname
2025-07-09 09:57:13.758 17936-17936 WindowOnBackDispatcher  com.nextcloud.talk2                  W  OnBackInvokedCallback is not enabled for the application.
                                                                                                    Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
2025-07-09 09:57:13.758 17936-17936 BrowserLoginActivity    com.nextcloud.talk2                  D  Start poolLogin
2025-07-09 09:57:13.771 17936-19785 TrafficStats            com.nextcloud.talk2                  D  tagSocket(183) with statsTag=0xffffffff, statsUid=-1
2025-07-09 09:57:14.003 17936-19785 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.io.IOException: Unexpected code Response{protocol=h2, code=404, message=, url=https://sermo.nextcloud.com/login/v2/poll}
2025-07-09 09:57:32.787 17936-18592 TrafficStats            com.nextcloud.talk2                  D  tagSocket(213) with statsTag=0xffffffff, statsUid=-1
2025-07-09 09:57:32.792 17936-19506 TrafficStats            com.nextcloud.talk2                  D  tagSocket(195) with statsTag=0xffffffff, statsUid=-1
2025-07-09 09:57:33.062 17936-19506 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.io.IOException: Unexpected code Response{protocol=h2, code=404, message=, url=https://sermo.nextcloud.com/login/v2/poll}
2025-07-09 09:57:33.064 17936-18592 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.io.IOException: Unexpected code Response{protocol=h2, code=404, message=, url=https://sermo.nextcloud.com/login/v2/poll}
2025-07-09 09:57:33.265 17936-18592 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.io.IOException: Unexpected code Response{protocol=h2, code=404, message=, url=https://sermo.nextcloud.com/login/v2/poll}
2025-07-09 09:57:44.278 17936-19785 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.io.IOException: Unexpected code Response{protocol=h2, code=404, message=, url=https://sermo.nextcloud.com/login/v2/poll}
2025-07-09 09:58:03.159 17936-18592 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.io.IOException: Unexpected code Response{protocol=h2, code=404, message=, url=https://sermo.nextcloud.com/login/v2/poll}
2025-07-09 09:58:03.162 17936-19506 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.io.IOException: Unexpected code Response{protocol=h2, code=404, message=, url=https://sermo.nextcloud.com/login/v2/poll}
2025-07-09 09:58:03.351 17936-18592 BrowserLoginActivity    com.nextcloud.talk2                  D  Error caught at performLoginFlowV2: java.io.IOException: Unexpected code Response{protocol=h2, code=404, message=, url=https://sermo.nextcloud.com/login/v2/poll}

Not sure yet if this is "solved" by just waiting 20minutes. But this wouldn't be a solution.

Some more things:
The first times i tried the sermo login, at some point i was automatically authenticated on web without to enter credentials (because it was still the same session?). So i was not even able to choose the user.

  • Do we want this behavior?
  • Is this ok regarding security?
  • What if i want to login as other user on the same instance?

Maybe @nickvergessen or @alperozturk96 have some insights (for server side or if there were similar topics on android files)?

@mahibi
Copy link
Collaborator

mahibi commented Jul 9, 2025

It works fine with chrome!

Before i had Firefox where it failed!
I connected to the mobile firefox via adb and i got this web console output (fyi @nickvergessen ):

12:49:57.806 Warnungen zu Content-Security-Policy 2
12:49:58.223 jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. [jquery-ui.css:1338:110](webpack:///nextcloud/node_modules/jquery-ui-dist/jquery-ui.css)
12:49:58.224 $ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. [jquery-ui.css:1338:110](webpack:///nextcloud/node_modules/jquery-ui-dist/jquery-ui.css)
12:49:58.237 Backbone is deprecated: please ship your own, this will be removed in Nextcloud 20 [jquery-ui.css:1338:110](webpack:///nextcloud/node_modules/jquery-ui-dist/jquery-ui.css)
12:49:58.238 Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20 [jquery-ui.css:1338:110](webpack:///nextcloud/node_modules/jquery-ui-dist/jquery-ui.css)
12:49:58.242
Uncaught TypeError: can't access property "call", s[t] is undefined
    Webpack 9
        a
        35810
        a
        81868
        a
        l
        O
        <anonymous>
        <anonymous>
[bootstrap:19:2](webpack:///nextcloud/webpack/bootstrap)
12:49:58.266 session heartbeat polling started [jquery-ui.css:687:20](webpack:///nextcloud/node_modules/jquery-ui-dist/jquery-ui.css)

See: https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Errors/Unexpected_type

mahibi

This comment was marked as resolved.

@mahibi
Copy link
Collaborator

mahibi commented Jul 10, 2025

The firefox problem (also discussed in https://cloud.nextcloud.com/call/dxbbx4jy#message_4154968) is now solved for me by reinstalling firefox 🤷‍♂️

So to sum up:
Yesterday it also worked initially with firefox, after that it didn't until the reinstall that i did now..

Something to keep in mind if it happens again, but i guess i won't be able to reproduce it now.

renamed WebViewLoginActivity.kt to BrowserLoginActivity.kt

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 force-pushed the issue-4711-login-flow-v2 branch from d2c8f8a to dad5f17 Compare July 10, 2025 13:13
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9796
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code6161
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9494

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5100-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@rapterjet2004 rapterjet2004 merged commit fa9768d into master Jul 10, 2025
16 checks passed
@rapterjet2004 rapterjet2004 deleted the issue-4711-login-flow-v2 branch July 10, 2025 13:34
@mahibi mahibi added this to the 21.2.0 milestone Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Flow v2
2 participants