Skip to content

Improve accessibility #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2025
Merged

Improve accessibility #5111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ca6acc
add content description to buttons
sowjanyakch Jul 1, 2025
8c0432e
add content description to buttons
sowjanyakch Jul 1, 2025
df2a820
add content description to buttons
sowjanyakch Jul 1, 2025
c208b3d
use proper wording recording instead of message
sowjanyakch Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/res/layout/call_activity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="@dimen/standard_quarter_margin"
android:contentDescription="@string/nc_call_button_content_description_microphone"
android:contentDescription="@string/nc_common_more_options"
app:backgroundTint="@color/call_buttons_background"
app:borderWidth="0dp"
app:fabCustomSize="40dp"
Expand All @@ -311,7 +311,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="@dimen/standard_quarter_margin"
android:contentDescription="@string/nc_call_button_content_description_microphone"
android:contentDescription="@string/end_call"
app:backgroundTint="@color/nc_darkRed"
app:borderWidth="0dp"
app:fabCustomSize="40dp"
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/fragment_message_input_voice_recording.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
android:layout_marginVertical="@dimen/standard_margin"
android:scaleType="centerInside"
android:src="@drawable/ic_delete"
android:contentDescription="@null"
android:contentDescription="@string/delete_voice_recording"
android:background="?android:attr/selectableItemBackgroundBorderless"
android:layout_weight="1"
/>
Expand All @@ -103,7 +103,7 @@
android:layout_marginVertical="@dimen/standard_margin"
android:scaleType="centerInside"
android:src="@drawable/ic_send"
android:contentDescription="@null"
android:contentDescription="@string/nc_send_voice_recording"
android:background="?android:attr/selectableItemBackgroundBorderless"
android:layout_weight="1"
/>
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/res/layout/view_message_input.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
android:layout_marginStart="@dimen/standard_double_margin"
android:scaleType="centerInside"
android:src="@drawable/ic_delete"
android:contentDescription="@null"
android:contentDescription="@string/delete_voice_recording"
android:background="?android:attr/selectableItemBackgroundBorderless"
android:visibility="gone" />

Expand All @@ -131,7 +131,7 @@
android:layout_marginEnd="@dimen/standard_double_margin"
android:scaleType="centerInside"
android:src="@drawable/ic_send"
android:contentDescription="@null"
android:contentDescription="@string/nc_send_voice_recording"
android:background="?android:attr/selectableItemBackgroundBorderless"
android:visibility="gone" />

Expand All @@ -147,7 +147,7 @@
android:scaleType="centerInside"
android:layout_alignParentStart="true"
android:src="@drawable/ic_baseline_mic_red_24"
android:contentDescription="@null"
android:contentDescription="@string/nc_microphone_enabled_audio_recording"
android:visibility="gone"
tools:visibility="gone" />

Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ How to translate with transifex:
<string name="nc_camera_permission_hint">To enable video communication please grant \"Camera\" permission.</string>
<string name="nc_microphone_permission_hint">To enable voice communication please grant \"Microphone\" permission.</string>
<string name="nc_bluetooth_permission_hint">To enable bluetooth speakers please grant \"Nearby devices\" permission.</string>
<string name="nc_microphone_enabled_audio_recording">Microphone is enabled and audio is recording</string>

<!-- Call -->
<string name="nc_call_voice">%s voice call</string>
Expand Down Expand Up @@ -332,6 +333,7 @@ How to translate with transifex:
<string name="call_running_since_one_hour">The call has been running for one hour.</string>
<string name="end_call_for_everyone">End call for everyone</string>
<string name="leave_call">Leave call</string>
<string name="end_call">End call</string>

<!-- Picture in Picture -->
<string name="nc_pip_microphone_mute">Mute microphone</string>
Expand Down Expand Up @@ -451,6 +453,7 @@ How to translate with transifex:
<item quantity="one">See %d similar message</item>
<item quantity="other">See %d similar messages</item>
</plurals>
<string name="nc_send_voice_recording">Send voice recording</string>

<!-- Conversation info guest access -->
<string name="nc_guest_access">Guest access</string>
Expand Down Expand Up @@ -591,6 +594,7 @@ How to translate with transifex:
<string name="play_pause_voice_message">Play/pause voice message</string>
<string name="nc_voice_message_missing_audio_permission">Permission for audio recording is required</string>
<string name="playback_speed_control">Playback speed control</string>
<string name="delete_voice_recording">Delete voice recording</string>

<!-- Phonebook Integration -->
<string name="nc_settings_phone_book_integration_desc">Match contacts based on phone number to integrate Talk shortcut into system contacts app</string>
Expand Down
Loading