Skip to content

hide thread messages in normal chat / include threadId in fieldMap ... #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2025
Merged

hide thread messages in normal chat / include threadId in fieldMap ... #5187

merged 5 commits into from
Jul 25, 2025

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Jul 25, 2025

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi added 5 commits July 25, 2025 12:53
@mahibi
include threadId in fieldMap
8bfbf83 
+ add test for getChatBlocksContainingMessageId

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
hide thread created system messages
a26d1c0 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
hide thread messages in normal chat
172d229 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
update threads overview in onResume
a7ca099 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
uncomment openHelperFactory
7fda688 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added this to the 22.0.0 milestone Jul 25, 2025
@mahibi mahibi self-assigned this Jul 25, 2025
@mahibi mahibi added the 3. to review Waiting for reviews label Jul 25, 2025
@mahibi mahibi enabled auto-merge July 25, 2025 11:02
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5187-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code6161
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9494

@mahibi mahibi disabled auto-merge July 25, 2025 12:47
@mahibi mahibi merged commit 30de714 into master Jul 25, 2025
16 of 18 checks passed
@mahibi mahibi deleted the feature/3074/messageThreads2 branch July 25, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
22.0.0
Development

Successfully merging this pull request may close these issues.

Message threads
1 participant
@mahibi