Skip to content

fix(mac): only keep app running after close when authenticated #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −14
Draft

fix(mac): only keep app running after close when authenticated #911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,20 +341,20 @@ app.whenReady().then(async () => {
mainWindow.once('ready-to-show', () => mainWindow.show())
}
})
})

app.on('window-all-closed', () => {
// Recreating a window - keep app running
if (isInWindowRelaunch) {
return
}

// On macOS, it is common for applications and their menu bar to stay active even without windows
// until the user quits explicitly with Cmd + Q or Quit from the menu.
if (isMac()) {
return
}
app.on('window-all-closed', () => {
// Recreating a window - keep app running
if (isInWindowRelaunch) {
return
}
// On macOS, it is common for applications and their menu bar to stay active even without windows
// until the user quits explicitly with Cmd + Q or Quit from the menu.
// However, it makes sense only for the Talk window and not for Authentication or Welcome windows.
if (isMac() && createMainWindow === createTalkWindow) {
return
}
// All the windows are closed - quit the app
app.quit()
})

// All the windows are closed - quit the app
app.quit()
})