Skip to content

Fix formatting of channel factories #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025

Conversation

bentsherman
Copy link
Member

@bentsherman bentsherman commented Jul 16, 2025

This PR updates the formatter to work with channel factories using the channel namespace instead of the Channel type. It ensures that a channel factory called via channel is kept on a single line instead of being wrapped across two lines.

@bentsherman bentsherman requested a review from pditommaso July 16, 2025 18:37
@bentsherman bentsherman requested a review from a team as a code owner July 16, 2025 18:37
Copy link

netlify bot commented Jul 16, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 204de83
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/688a4549afbdc80008a45a2d

@bentsherman bentsherman marked this pull request as draft July 16, 2025 21:57
@bentsherman
Copy link
Member Author

Reverting to draft. Need to move helper functions to Types instead of ASTUtils

@bentsherman bentsherman requested review from jorgee and removed request for pditommaso July 28, 2025 15:38
@bentsherman bentsherman force-pushed the fix-channel-namespace-formatting branch from 44355cd to 3f04ea0 Compare July 28, 2025 15:38
@bentsherman bentsherman marked this pull request as ready for review July 28, 2025 15:38
@jorgee
Copy link
Contributor

jorgee commented Jul 30, 2025

Could you provide some context about the change in the description?

@bentsherman
Copy link
Member Author

updated

@jorgee
Copy link
Contributor

jorgee commented Jul 30, 2025

If I understood correctly, in the case ofChannel(that is deprecated), the formatting rule is not applied and the factory is splitted in a separate line. Is this the expected behaviour?

@bentsherman
Copy link
Member Author

yes, no need to maintain the old formatting rule since it's deprecated anyway

@bentsherman bentsherman merged commit f73f87b into master Jul 30, 2025
22 checks passed
@bentsherman bentsherman deleted the fix-channel-namespace-formatting branch July 30, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants