AzureRepositoryProvider readBytes corrupt #6286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Johnson <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
reviewed
Jul 22, 2025
modules/nextflow/src/test/groovy/nextflow/scm/AzureRepositoryProviderTest.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Di Tommaso <[email protected]>
Changed Azure API call from JSON-embedded content to direct binary download using 'download: true' parameter. This prevents binary data corruption that occurred when converting JSON-escaped strings back to bytes. The test now passes with correct file size (22,915 bytes) and SHA256 hash. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
pditommaso
approved these changes
Jul 22, 2025
pditommaso
reviewed
Jul 22, 2025
modules/nextflow/src/test/groovy/nextflow/scm/GiteaRepositoryProviderTest.groovy
Outdated
Show resolved
Hide resolved
…roviderTest.groovy [ci skip] Signed-off-by: Paolo Di Tommaso <[email protected]>
|
Still some aws infra tests issue tho :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AzureRepositoryProvider readBytes method appears to corrupt data for image files.
This PR contains 2 identical tests for a Gitea and Azure repo, both of which simple readBytes for an image in each and check whether the bytes returned are a valid image. The Gitea test passes whilst the Azure test fails.
The tests are currently set up with a public Gitea repo, so the existing auth should work for that. The azure repo is private, so will need changing to a repo which the current CI env has access to.