Fix error with dynamic directives with named arguments #6550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6512
This PR fixes an apparent regression in 25.10. The following directives fail when they are specified with a closure that references a process input:
This has to do with how they are implemented in
ProcessBuilder. Most directives aren't implemented explicitly, but these directives require explicit methods in order to handle named arguments.I'm not sure why it works in 25.04 but not in 25.10, since the logic of these methods were not changed when they were moved to
ProcessBuilder. I suspect it was being held together with some hidden Groovy magic 🤷Test case derived from the issue:
I added a simplified version of this to the e2e tests.