Modernize arm profiles #8821
Open
Modernize arm profiles #8821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: ARM profile names have been updated to better reflect their purpose: - `arm` profile renamed to `arm64` with native ARM64 support using Wave containers - `arm_CI` profile renamed to `arm64_CI` for consistency - Added `emulate_amd64` profile for x86 emulation on ARM hardware Migration: - Replace `-profile arm` with `-profile arm64` for native ARM64 execution - Use `-profile emulate_amd64` for x86 emulation on ARM hardware - Update CI workflows using `arm_CI` to use `arm64_CI` This aligns with the ARM profile modernization in nf-core/tools (issue #3536). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The arm64_CI profile was functionally identical to the main arm64 profile. The arm64 profile already provides proper ARM64 architecture support with Wave containers, making the separate CI profile unnecessary. Any CI workflows using arm64_CI should switch to the main arm64 profile.
Update nf-test.yml workflow to use the new arm64 profile instead of the removed arm_CI profile. This ensures ARM64 CI tests continue to work with the modernized profile names.
edmundmiller
force-pushed
the
modernize-arm-profiles
branch
from
b8fc773 to
98638b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the nf-core/modules repository with the ARM profile modernization from nf-core/tools, providing clearer distinction between native ARM64 support and x86 emulation. This should align with nf-core/tools#3689
Changes Made
Profile Updates:
CI Integration:
Benefits
Migration Guide