Skip to content

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Aug 12, 2025

I ran this on all sarek modules:

nextflow lint -format -sort-declarations -spaces 4 -harshil-alignment ...

(and fixed the issues)

Split in:

Reducing scope:

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to get all of the tests to pass?

@maxulysse
Copy link
Member Author

Is the plan to get all of the tests to pass?

yes, but mainly more by splitting up this PR.
This one is more my checklist

@maxulysse maxulysse marked this pull request as draft August 19, 2025 14:52
@maxulysse maxulysse changed the title Lint modules for sarek Lint + code polish modules for sarek Aug 19, 2025
@SPPearce
Copy link
Contributor

@maxulysse , can we close this now?

@maxulysse maxulysse closed this Oct 20, 2025
@maxulysse maxulysse deleted the sarek_lint branch October 20, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants