update module: spaceranger #8911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundmiller
approved these changes
Aug 23, 2025
There was a problem hiding this comment.
| @@ -2,89 +2,89 @@ | |||
| "spaceranger v1 (stub) - homo_sapiens - fasta - gtf - fastq - tif - csv": { | |||
| "content": [ | |||
| [ | |||
| "versions.yml:md5,4abe169f33d7f99d5d9876b189060aae" | |||
There was a problem hiding this comment.
While you have Space Ranger up and running, can you make a follow-up PR to swap out the versions.yaml?
Might save us some time in the future. 😅
camlloyd
commented
Aug 25, 2025
| @@ -1,10 +1,10 @@ | |||
| # syntax=docker/dockerfile:1 | |||
|
|
|||
| FROM mambaorg/micromamba:1.5.10-jammy | |||
| ARG SPACERANGER_VER="3.1.3" | |||
| ARG SPACERANGER_VER="4.0.1" | |||
| # NOTE you need to go fill out the form to get a new download link | |||
There was a problem hiding this comment.
I guess not now? You do just need to go get a new link?
There was a problem hiding this comment.
I have tried a few times and it looks to be as simple as that! I will remove this comment from the Dockerfile now.
Add a new job that warns when fork PRs modify Dockerfile or environment.yml files. This addresses the issue where container builds silently fail to run on fork PRs due to security restrictions, providing clear feedback to contributors and maintainers. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #8910 by bumping the spaceranger version in the Dockerfile, also update the README.
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda