-
Notifications
You must be signed in to change notification settings - Fork 911
Add fastq seqkit sana pair #9185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good @vagkaratzas! A few minor comments/questions
Co-authored-by: James A. Fellows Yates <[email protected]>
…ing strandness on the meta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Two minor comments - I don't think they're blocking, but definitely the config file one would IMO be nice-to-have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as Jim, no major blockers now
Thank you both! |
New
fastq
file sanitization/pre-processing subworkflow, to be used instead of justseqkit/sana
, that automatically breaks paired-end reads (seqkit/sana
can only process one file at a time), mixes with single-end reads in one channel, runsseqkit/sana
and finally merges back original pairs withseqkit/pair
.PR checklist
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda