-
Notifications
You must be signed in to change notification settings - Fork 911
add cmaple software #9189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cmaple software #9189
Conversation
""" | ||
input[0] = [ | ||
[ id:'test_aa' ], | ||
file(params.modules_testdata_base_path + '../../multiplesequencealign/testdata/setoxin.ref', checkIfExists: true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the ../../
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test file comes from the multiplesequencealign branch test datasets, instead of modules. It is also used across other nf-core modules with this format. This file is better suited for the cmaple tests. Shall I maybe push this alignment file to the nf-core/test-datasets modules branch as well? Or keep like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh I see.
nice trick to get data from another branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't be allowed unfortunately for modules tests in the modules repo.
Could you put this file in the nf-core/test-datasets
modules branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out that a similar file was already on the modules
branch named seatoxin-ref.aln
instead of setoxin-ref
. So I adjusted to source that instead!
New module that produces predicted phylogenetic trees from multiple sequence alignment files (both for DNA and Amino Acids)
PR checklist
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda