Skip to content

Copy optimized resources from Tower #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Copy optimized resources from Tower #1209

wants to merge 1 commit into from

Conversation

@edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Feb 6, 2024

No description provided.

@edmundmiller edmundmiller self-assigned this Feb 6, 2024
@github-actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4ab3ecb

+| ✅ 169 tests passed       |+
#| ❔  10 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowRnaseq.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • nextflow_config - Config default ignored: params.ribo_database_manifest
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File does not exist: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-06 15:49:37

@JoseEspinosa
Copy link
Member

JoseEspinosa commented Feb 6, 2024

The platform config does not lint 😱

@edmundmiller edmundmiller requested a review from FloWuenne April 30, 2025 13:26
FloWuenne
FloWuenne requested changes Apr 30, 2025
View reviewed changes
conf/test_full.config
Comment on lines +237 to +238
errorStrategy = 'retry'
maxRetries = 2
Copy link

@FloWuenne FloWuenne Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
errorStrategy = 'retry'
maxRetries = 2

Let's not change the retry and maxRetries strategies though!

Copy link
Contributor Author

@edmundmiller edmundmiller Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, maybe it should if we have an optimized run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloWuenne FloWuenne FloWuenne requested changes

@mashehu mashehu Awaiting requested review from mashehu

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

@drpatelh drpatelh Awaiting requested review from drpatelh

Requested changes must be addressed to merge this pull request.

Assignees

@edmundmiller edmundmiller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edmundmiller @JoseEspinosa @FloWuenne