Skip to content

Conversation

vvnginx
Copy link
Contributor

@vvnginx vvnginx commented Aug 20, 2025

Proposed changes

fix: Add support for NAP v4.16.0/v5.8.0 in NIM
//: # "Write a clear and concise description of what the pull request changes."
//: # "You can use our Commit messages guidance for this."
//: # "https://github.com/nginx/documentation/blob/main/documentation/git-conventions.md#commit-messages"

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@vvnginx vvnginx requested a review from a team as a code owner August 20, 2025 07:36
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager labels Aug 20, 2025
@mjang
Copy link
Contributor

mjang commented Aug 25, 2025

Note, in commit ce1cf1a

I resolved conflicts in favor of PR #1000

@vvnginx , let me know if that's OK or a mistake.

@vvnginx
Copy link
Contributor Author

vvnginx commented Aug 25, 2025

Note, in commit ce1cf1a

I resolved conflicts in favor of PR #1000

@vvnginx , let me know if that's OK or a mistake.

Yes @mjang , That's perfect.. Thank you so much!

@mjang mjang merged commit 25c12b2 into nginx:main Aug 25, 2025
7 checks passed
@vvnginx vvnginx deleted the patch-5 branch August 25, 2025 13:36
lamATnginx pushed a commit that referenced this pull request Aug 26, 2025
* fix: Update setup-waf-config-management.md

* fix: Update nim-app-protect-support.md

Now NIM supports NAP version 4.16.0 and 5.8.0 as well!

---------

Co-authored-by: Mike Jang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants