-
Notifications
You must be signed in to change notification settings - Fork 2k
#6679 add globalConfigurationCustomName parameter #6680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frantsao
wants to merge
27
commits into
nginx:main
Choose a base branch
from
frantsao:issue-6679
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−1
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
812e7ef
Helm: add globalConfigurationCustomName parameter
frantsao 24720e9
Merge branch 'main' into issue-6679
frantsao 1db8f4a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 548ac11
Remove unneeded comment in values.yaml
frantsao db5c8f4
Merge branch 'main' into issue-6679
frantsao e09ada1
Merge branch 'main' into issue-6679
frantsao 8d64188
Merge branch 'main' into issue-6679
frantsao 4f4b1db
Merge branch 'main' into issue-6679
frantsao 5a57015
Merge branch 'main' into issue-6679
frantsao ee5c86b
Merge branch 'main' into issue-6679
frantsao 610f49e
moved globalConfigurationCustomName parameter to globalConfiguration.…
frantsao 0823d8d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3969d8b
Fix values.schema.json format
frantsao 151ef1b
Merge remote-tracking branch 'refs/remotes/origin/issue-6679' into is…
frantsao d7d59aa
Merge branch 'main' into issue-6679
frantsao ae76aea
Merge branch 'main' into issue-6679
frantsao 8490da9
Helm: add globalConfigurationCustomName parameter
frantsao f8681b7
Helm: add globalConfigurationCustomName parameter
frantsao 40f944b
Merge branch 'main' into issue-6679
frantsao b952899
Merge branch 'main' into issue-6679
frantsao d28a769
Merge branch 'main' into issue-6679
frantsao 5b1c592
Merge branch 'main' into issue-6679
frantsao 8ef8c23
Merge branch 'main' into issue-6679
frantsao 56b971d
Merge branch 'main' into issue-6679
frantsao 0373dee
Merge branch 'main' into issue-6679
frantsao 8ef2afa
Merge branch 'main' into issue-6679
frantsao 1674a9b
Merge branch 'main' into issue-6679
frantsao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -397,6 +397,9 @@ controller: | |
## Creates the GlobalConfiguration custom resource. Requires controller.enableCustomResources. | ||
create: false | ||
|
||
## customName: "the-namespace/the-name-of-the-global-configuration-custom-resource" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add a comment here about making sure this namespace is watched when |
||
## The name of the GlobalConfiguration custom resource to use instead of the one provided by default. | ||
|
||
## The spec of the GlobalConfiguration for defining the global configuration parameters of the Ingress Controller. | ||
spec: {} ## Ensure both curly brackets are removed when adding listeners in YAML format. | ||
# listeners: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to have the chart apply fail if
.Values.controller.globalConfiguration.customName
doesn't contain a/