Skip to content

Always build the binary when we force a rebuild #7981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jul 2, 2025

Proposed changes

  • If the workflow is triggered by a workflow_dispatch and a force rebuild is requested, always rebuild the binary and don't check the build cache.
  • If the workflow is triggered by a workflow_dispatch, allow the user to disable running the tests, this allows building the binary and/or docker containers if they don't yet exist.
  • Un-pin the k8s version used in the e2e tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner July 2, 2025 16:45
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jul 2, 2025
@pdabelf5 pdabelf5 marked this pull request as draft July 2, 2025 16:45
@pdabelf5 pdabelf5 marked this pull request as ready for review July 3, 2025 12:28
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.95%. Comparing base (65a3082) to head (8842e25).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7981      +/-   ##
==========================================
+ Coverage   52.93%   52.95%   +0.01%     
==========================================
  Files          90       90              
  Lines       21729    21729              
==========================================
+ Hits        11502    11506       +4     
+ Misses       9748     9746       -2     
+ Partials      479      477       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants