-
Notifications
You must be signed in to change notification settings - Fork 2k
Ensure packages are installed on images #7991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm also thinking from a code perspective, we have 3 pairs of cmd/regex based on base os. I wonder if it'd be better to specify the OS in the json, and have a map to grab the cmd / regex. Super tiny nit, just preference, so feel free to ignore it. Reason for including: in case a change only affects only some of the regexes / commands for the same base os. I do really like the idea! Excellent work! 🙌🏻 |
stretch goal: generate report as a part of workflow after the images are built, similar to DockerScout action in CI jobs where we get list of CVEs. Instead we get list of modules installed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7991 +/- ##
=======================================
Coverage 52.95% 52.95%
=======================================
Files 90 90
Lines 21729 21729
=======================================
Hits 11506 11506
Misses 9746 9746
Partials 477 477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d2bfa29
to
5fa0f2e
Compare
Package Report
|
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.