-
Notifications
You must be signed in to change notification settings - Fork 2k
Add SNI to NIC JWT Policy #7993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
javorszky
wants to merge
16
commits into
main
Choose a base branch
from
feat/7427-sni-in-jwt-policy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7993 +/- ##
==========================================
+ Coverage 52.95% 52.97% +0.02%
==========================================
Files 90 90
Lines 21729 21747 +18
==========================================
+ Hits 11506 11521 +15
- Misses 9746 9747 +1
- Partials 477 479 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8e60efa
to
76d3797
Compare
10 tasks
5a23849
to
7c2c3e4
Compare
vepatel
reviewed
Jul 10, 2025
vepatel
reviewed
Jul 10, 2025
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
6 tasks
vepatel
previously approved these changes
Jul 15, 2025
AlexFenlon
previously approved these changes
Jul 15, 2025
Package Report
|
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
…o feat/7427-sni-in-jwt-policy
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Pull requests for new features/feature enhancements
go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #7427
Adds the ability to specify SNI related options for jwt policies.
There are two configuration options:
sniEnabled
, which controls the value of theproxy_ssl_server_name
nginx directive, andsniName, which controls the value of the
proxy_ssl_name` nginx directiveSpecifying
sniName
without SNI being enabled will result in an error.Documentation PR: nginx/documentation#795
Checklist
Before creating a PR, run through this checklist and mark each as complete.