-
Notifications
You must be signed in to change notification settings - Fork 2k
Add Safer Proxy_Buffer Config #8088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nabled and vise versa
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8088 +/- ##
==========================================
+ Coverage 53.11% 53.44% +0.33%
==========================================
Files 90 90
Lines 21778 22003 +225
==========================================
+ Hits 11567 11760 +193
- Misses 9736 9763 +27
- Partials 475 480 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Package Report
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx, 1.27.5-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-module-njs, 1.27.5+0.8.10-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-module-otel, 1.27.5+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-agent, 3.0.3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx, 1.27.5-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-module-njs, 1.27.5+0.8.10-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-module-otel, 1.27.5+0.1.2-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-agent, 3.0.3~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-agent, 3.0.3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus, 34-2~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-njs, 34+0.8.9-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-otel, 34+0.1.1-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-fips-check, 34+0.1-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-agent, 3.0.3~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect-attack-signatures, 2025.07.24-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect-threat-campaigns, 2025.07.29-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-agent, 2.42.1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect-module-plus, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect-plugin, 6.16.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-agent, 2.42.0~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-appprotectdos, 34+4.6.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect-dos, 34+4.6.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus, 34-2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect, 34+5.442.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect-attack-signatures, 2025.07.24-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect-threat-campaigns, 2025.07.29-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-plus-module-appprotectdos, 34+4.6.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, app-protect-dos, 34+4.6.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332, nginx-agent, 2.42.0~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx, 1.27.5-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-module-njs, 1.27.5.0.8.10-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-module-otel, 1.27.5.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-agent, 3.0.3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx, 1.27.5-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-module-njs, 1.27.5.0.8.10-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-module-otel, 1.27.5.0.1.2-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-agent, 3.0.3, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-plus, 34-r2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-plus-module-njs, 34.0.8.9-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-plus-module-otel, 34.0.1.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-plus-module-fips-check, 34.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-agent, 3.0.3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-plus, 34-r2, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-plus-module-njs, 34.0.8.9-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-plus-module-otel, 34.0.1.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-plus-module-fips-check, 34.0.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine, nginx-agent, 3.0.3, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus, 34-r2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-agent, 3.0.3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus, 34-r2, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-agent, 3.0.3, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus, 34-r2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-agent, 2.42.1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-appprotect, 34.5.442.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, app-protect, 34.5.442.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, app-protect-attack-signatures, 2025.07.24-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, app-protect-threat-campaigns, 2025.07.29-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus, 34-r2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-agent, 2.42.0, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, nginx-plus-module-appprotect, 34.5.442.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, app-protect-module-plus, 34.5.442.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-alpine-fips, app-protect-plugin, 6.16.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx, 1.27.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-module-njs, 1.27.5+0.9.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-module-otel, 1.27.5+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-agent, 3.0.3-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx, 1.27.5-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-module-njs, 1.27.5+0.9.0-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-module-otel, 1.27.5+0.1.2-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-agent, 3.0.3-1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-agent, 3.0.3-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus, 34-2.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-agent, 3.0.3-1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-agent, 2.42.1-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect-attack-signatures, 2025.07.24-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect-threat-campaigns, 2025.07.29-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-agent, 2.42.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect-module-plus, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect-plugin, 6.16.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus, 34-2.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus-module-njs, 34+0.8.9-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus-module-otel, 34+0.1.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus-module-fips-check, 34+0.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-agent, 2.42.1-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus-module-appprotect, 34+5.442.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, app-protect, 34+5.442.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, app-protect-attack-signatures, 2025.07.24-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, app-protect-threat-campaigns, 2025.07.29-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus, 34-2.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus-module-njs, 34+0.8.9-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus-module-otel, 34+0.1.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus-module-fips-check, 34+0.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-agent, 2.42.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, nginx-plus-module-appprotect, 34+5.442.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, app-protect-module-plus, 34+5.442.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi8, app-protect-plugin, 6.16.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-appprotectdos, 34+4.6.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect-dos, 34+4.6.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus, 34-2.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-plus-module-appprotectdos, 34+4.6.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, nginx-agent, 2.42.0-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect, 34+5.442.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect-attack-signatures, 2025.07.24-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect-threat-campaigns, 2025.07.29-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f87083d4e69aef0b758b8c88feece332-ubi, app-protect-dos, 34+4.6.1-1.el9.ngx, x86_64 |
…at/safe-buffer-config # Conflicts: # internal/configs/commonhelpers/common_template_helpers.go # internal/configs/commonhelpers/common_template_helpers_test.go
@@ -168,6 +168,7 @@ The `.spec` object supports the following fields: | |||
| `upstreams[].buffers` | `object` | Configures the buffers used for reading a response from the upstream server for a single connection. | | |||
| `upstreams[].buffers.number` | `integer` | Configures the number of buffers. The default is set in the proxy-buffers ConfigMap key. | | |||
| `upstreams[].buffers.size` | `string` | Configures the size of a buffer. The default is set in the proxy-buffers ConfigMap key. | | |||
| `upstreams[].busy-buffers-size` | `string` | Sets the size of the buffers used for reading a response from the upstream server when the proxy_buffering is enabled. The default is set in the proxy-busy-buffers-size ConfigMap key.' | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given the existing naming convension, shouldn't this be
upstreams[].buffers.busy-size
count := 4 | ||
if proxyBusyBuffersSize != "" { | ||
bufferSizeBytes := validation.ParseSize(proxyBufferSize) | ||
if bufferSizeBytes > 0 { | ||
minBuffers := int((validation.ParseSize(proxyBusyBuffersSize) + bufferSizeBytes) / bufferSizeBytes) | ||
if minBuffers > count { | ||
count = minBuffers | ||
} | ||
} | ||
} | ||
proxyBuffers = fmt.Sprintf("%d %s", count, proxyBufferSize) | ||
parts = append(parts, fmt.Sprintf("proxy_buffer_size %s", proxyBufferSize), fmt.Sprintf("proxy_buffers %s", proxyBuffers)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be refactored to make the code more readable, i.e. a function named after what we want to do
fields := strings.Fields(proxyBuffers) | ||
if len(fields) < 2 { | ||
if proxyBusyBuffersSize == "" { | ||
return "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we not return an error here?
Proposed changes
nginx.org/proxy-busy-buffers-size
annotation to ingressproxy-busy-buffers-size
to configmapbusy-buffers-size
to VirtualServerDocs PR: nginx/documentation#917
Solves : #8004
Checklist
Before creating a PR, run through this checklist and mark each as complete.