Skip to content

Specify patch version for go docker image #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Specify patch version for go docker image #1091

wants to merge 1 commit into from

Conversation

LoicDaval-Amadeus
Copy link

@LoicDaval-Amadeus LoicDaval-Amadeus commented Jun 23, 2025 •
edited
Loading

Proposed changes

Specifying the patch version of the go docker image should allow renovate to propose version updates for patch version that ca contain security updates like it is the case for go 1.21.4 --> 1.24.4 which fixes some non major CVE

Fixes #1090

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@LoicDaval-Amadeus LoicDaval-Amadeus requested a review from a team as a code owner June 23, 2025 14:47
@nginx-bot nginx-bot
Copy link

nginx-bot bot commented Jun 23, 2025

Hi @LoicDaval-Amadeus! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community Issues or PRs opened by an external contributor label Jun 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 23, 2025 •
edited
Loading

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@LoicDaval-Amadeus
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

@LoicDaval-Amadeus
Copy link
Author

I don't know your processes but this PR is actually useless IF you have some regular build to deliver rebuilt images in such case pinning the patch version will result in the regular build not updating anymore and requiring a renovate merge.
But I feel the renovate merge is the clean way to go

@LoicDaval-Amadeus
Specify patch version for go docker image
86a1459 
It allows renovate to find upadted of the go docker image, and propose a
bump of patch version that can be a source of security updates like it
is for go 1.21.4 --> 1.24.4 which fixes some not major CVE
@LoicDaval-Amadeus LoicDaval-Amadeus force-pushed the dockerfile_go_version_patch branch from b24b9ac to 86a1459 Compare July 2, 2025 13:20
@LoicDaval-Amadeus
Copy link
Author

Hello, kindly asking for an update on this one.

@jjngx
Copy link
Contributor

jjngx commented Jul 14, 2025

golang:1.24.5 is out. Why not to bump up to v1.24.5?

@bjee19
Copy link

bjee19 commented Jul 14, 2025

I think 1.24.5 came out after this PR was opened, but yea bumping to that version would be good, then this PR looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javorszky javorszky javorszky approved these changes

@bjee19 bjee19 bjee19 approved these changes

Assignees
No one assigned
Labels
community Issues or PRs opened by an external contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate missing update for patch version of Go
4 participants
@LoicDaval-Amadeus @jjngx @bjee19 @javorszky