Skip to content

Conversation

@dareste
Copy link
Contributor

@dareste dareste commented Oct 22, 2025

Proposed changes

The changes here address the issue in #161.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dareste dareste requested a review from a team as a code owner October 22, 2025 10:06
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.37%. Comparing base (eaaaa89) to head (25b19b1).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   76.63%   77.37%   +0.74%     
==========================================
  Files          27       30       +3     
  Lines        1164     1463     +299     
==========================================
+ Hits          892     1132     +240     
- Misses        216      276      +60     
+ Partials       56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ornj ornj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comment: It would be nice to see a test along with the change, especially as it is fixing a bug. Since this directive was modified by hand maybe the issue comes back.

Copy link
Contributor

@ryepup ryepup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The tests are more verbose than I like, but that's "me" problem, and it's following the patterns already in the codebase.

@ryepup ryepup merged commit 8aceeda into nginxinc:main Oct 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants