-
Notifications
You must be signed in to change notification settings - Fork 20
fix: wrong flag in ssl_ocsp #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 76.63% 77.37% +0.74%
==========================================
Files 27 30 +3
Lines 1164 1463 +299
==========================================
+ Hits 892 1132 +240
- Misses 216 276 +60
+ Partials 56 55 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with comment: It would be nice to see a test along with the change, especially as it is fixing a bug. Since this directive was modified by hand maybe the issue comes back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The tests are more verbose than I like, but that's "me" problem, and it's following the patterns already in the codebase.
Proposed changes
The changes here address the issue in #161.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)