Skip to content

Conversation

@mikeprosserni
Copy link
Contributor

@mikeprosserni mikeprosserni commented Dec 16, 2025

What does this Pull Request accomplish?

ni.measurementlink.sessionmanagement.v1.proto:

  • in pyproject.toml, update the nitypes version from ">=0.1.0dev3" to ">=1.0"
  • in pyproject.toml, remove the nitypes dependancy
  • in poetry.lock, nitypes is now "1.0.1.dev0"
  • (note, running 'poetry lock' also removed a bunch of stuff)

ni.protobuf.types:

  • in pyproject.toml, update the nitypes version from ">=1.1.0dev0" to ">=1.1.0dev1"
  • in poetry.lock, nitypes is now "1.1.0.dev1"
  • (note, running 'poetry lock' also removed a bunch of stuff)

Why should this Pull Request be merged?

This ensures that ni.measurementlink.sessionmanagement.v1.proto and ni.protobuf.types have the "Reverse Indices for Digital Waveform Signals" bugfix (ni/nitypes-python#222) (ni/nitypes-python#233)

What testing has been done?

All 130 tests in ni.protobuf.types pass

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Test Results

  120 files  ±0    120 suites  ±0   3m 35s ⏱️ +8s
  249 tests ±0    247 ✅ ±0   2 💤 ±0  0 ❌ ±0 
2 490 runs  ±0  2 460 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 5d84528. ± Comparison against base commit ec5c154.

♻️ This comment has been updated with latest results.

@mikeprosserni mikeprosserni marked this pull request as ready for review December 16, 2025 19:22
@mikeprosserni mikeprosserni merged commit 58b93cd into main Dec 16, 2025
348 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/nitypes-1.0.1.dev0 branch December 16, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants