Skip to content

Conversation

@HSKhor-NI
Copy link
Contributor

@HSKhor-NI HSKhor-NI commented Oct 29, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Adding new python API for DAQmxCreateAICalculatedPowerChan.

Why should this Pull Request be merged?

Python API is required for the new CreateAICalculatedPowerChan API for 26Q1 release

What testing has been done?

Run unit test locally:
image

@HSKhor-NI HSKhor-NI changed the title [26.0] Add DAQmxCreateAICalculatedPowerChan python API [Draft-CI-Build] Add DAQmxCreateAICalculatedPowerChan python API Oct 29, 2025
@StephenLeeChin
Copy link

Test comment

@HSKhor-NI HSKhor-NI marked this pull request as ready for review November 10, 2025 06:25
@HSKhor-NI HSKhor-NI changed the title [Draft-CI-Build] Add DAQmxCreateAICalculatedPowerChan python API [26Q1] Add DAQmxCreateAICalculatedPowerChan python API Nov 10, 2025
@HSKhor-NI
Copy link
Contributor Author

Due to the addition of ReadAnalogWaveform feature in grpc-device, when trying to sync the latest nidaqmx.proto and other metadata files from grpc-device, it will cause the codegen to fail.
image

Hence I manually removed all the ReadAnalogWaveform related changes from nidaqmx.proto and other metadata files as a temporary workaround to unblock the virtual power channel development. Just a FYI to @mikeprosserni.

@HSKhor-NI HSKhor-NI closed this Nov 10, 2025
@HSKhor-NI HSKhor-NI reopened this Nov 10, 2025
@HSKhor-NI HSKhor-NI requested review from bkeryan and zhindes November 11, 2025 07:07
@zhindes zhindes changed the title [26Q1] Add DAQmxCreateAICalculatedPowerChan python API [26Q1] Add features from DAQmx 26.0 release (Calculated Power and A, C-type Thermocouples) Nov 11, 2025
Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issue with ini

@HSKhor-NI
Copy link
Contributor Author

Hello @maxxboehme, could I get your help to review and merge this PR?

@zhindes
Copy link
Collaborator

zhindes commented Nov 19, 2025

Hello @maxxboehme, could I get your help to review and merge this PR?

Maxx isn't very active here, you're good to complete this when you're ready.

EDIT: Specifically, you can hit Squash and Merge button after Brad and I approve and the PR builds pass

@bkeryan
Copy link
Collaborator

bkeryan commented Nov 19, 2025

EDIT: Specifically, you can hit Squash and Merge button after Brad and I approve and the PR builds pass

@zhindes, @HSKhor-NI doesn't have write access yet.

Also, the PR workflow results don't match the required checks because I changed them for #890, so I'll bypass the required checks and squash-merge.

@bkeryan bkeryan merged commit 23ea226 into ni:master Nov 19, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants