waveform: Add __eq__ and __repr__ magic methods #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
force-pushed
the
users/bkeryan/append-waveform
branch
from
53aaf60 to
6934f10
Compare
bkeryan
force-pushed
the
users/bkeryan/waveform-magic
branch
from
cf223c9 to
66b0af6
Compare
bkeryan
force-pushed
the
users/bkeryan/append-waveform
branch
from
3caa239 to
18a9000
Compare
bkeryan
force-pushed
the
users/bkeryan/waveform-magic
branch
2 times, most recently
from
65b8cca to
245b6b3
Compare
bkeryan
force-pushed
the
users/bkeryan/append-waveform
branch
from
bead0e1 to
2d6664c
Compare
bkeryan
force-pushed
the
users/bkeryan/waveform-magic
branch
from
245b6b3 to
6569aa6
Compare
bkeryan
force-pushed
the
users/bkeryan/waveform-magic
branch
from
6569aa6 to
0807d90
Compare
Contributor
jfriedri-ni
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Enable the
==and!=operators to compare waveforms by value.Enable the
str()andrepr()functions to display a text representation of a waveform.Rearrange the
AnalogWaveformconstructor parameters to match therepr()function output and allow specifying extended properties, timing, and scaling at construction time.Why should this Pull Request be merged?
Closes AB#3097256 - Support eq/repr
What testing has been done?
Ran unit tests