generated from ni/github-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 3
waveform: Implement copy and pickle #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
245b6b3 to
6569aa6
Compare
161c16d to
29fdb7d
Compare
bkeryan
commented
Apr 29, 2025
6569aa6 to
0807d90
Compare
48ff72f to
6c2fe3f
Compare
bkeryan
commented
Apr 29, 2025
6c2fe3f to
28d425b
Compare
Contributor
Test Results 10 files ± 0 10 suites ±0 25s ⏱️ ±0s Results for commit 985ba65. ± Comparison against base commit 375f6da. This pull request removes 28 and adds 134 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
bkeryan
commented
Apr 30, 2025
jfriedri-ni
approved these changes
Apr 30, 2025
…y the timestamps list by default
7b000c2 to
985ba65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Enable support for the standard
copyandpicklemodules.Add tests for
copy.copy,copy.deepcopy, andpickle.Remove
copyusage from equality tests.Document that waveform timing objects are immutable and change their constructor to copy the timestamps list by default.
Why should this Pull Request be merged?
Closes AB#3107357: Support copy/pickle
What testing has been done?
Ran updated tests.