Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Apr 28, 2025

What does this Pull Request accomplish?

Enable support for the standard copy and pickle modules.

Add tests for copy.copy, copy.deepcopy, and pickle.

Remove copy usage from equality tests.

Document that waveform timing objects are immutable and change their constructor to copy the timestamps list by default.

Why should this Pull Request be merged?

Closes AB#3107357: Support copy/pickle

What testing has been done?

Ran updated tests.

@bkeryan bkeryan requested a review from csjall as a code owner April 28, 2025 22:36
@bkeryan bkeryan force-pushed the users/bkeryan/waveform-magic branch from 245b6b3 to 6569aa6 Compare April 28, 2025 23:50
@bkeryan bkeryan force-pushed the users/bkeryan/waveform-copy-pickle branch from 161c16d to 29fdb7d Compare April 28, 2025 23:57
@bkeryan bkeryan force-pushed the users/bkeryan/waveform-magic branch from 6569aa6 to 0807d90 Compare April 29, 2025 21:44
@bkeryan bkeryan force-pushed the users/bkeryan/waveform-copy-pickle branch 2 times, most recently from 48ff72f to 6c2fe3f Compare April 29, 2025 22:39
@bkeryan bkeryan requested a review from jfriedri-ni April 29, 2025 22:40
Base automatically changed from users/bkeryan/waveform-magic to main April 30, 2025 15:48
@bkeryan bkeryan force-pushed the users/bkeryan/waveform-copy-pickle branch from 6c2fe3f to 28d425b Compare April 30, 2025 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025

Test Results

   10 files  ±    0     10 suites  ±0   25s ⏱️ ±0s
  497 tests +  106    497 ✅ +  111  0 💤  -  5  0 ❌ ±0 
4 970 runs  +1 060  4 970 ✅ +1 110  0 💤  - 50  0 ❌ ±0 

Results for commit 985ba65. ± Comparison against base commit 375f6da.

This pull request removes 28 and adds 134 tests. Note that renamed tests count towards both.
tests.unit.waveform._timing.test_precision ‑ test___deep_copy___equality___equal[value0]
tests.unit.waveform._timing.test_precision ‑ test___deep_copy___equality___equal[value1]
tests.unit.waveform._timing.test_precision ‑ test___deep_copy___equality___equal[value2]
tests.unit.waveform._timing.test_precision ‑ test___deep_copy___equality___equal[value3]
tests.unit.waveform._timing.test_precision ‑ test___deep_copy___equality___equal[value4]
tests.unit.waveform._timing.test_precision ‑ test___deep_copy___equality___equal[value5]
tests.unit.waveform._timing.test_precision ‑ test___deep_copy___equality___equal[value6]
tests.unit.waveform._timing.test_precision ‑ test___deep_copy___equality___equal[value7]
tests.unit.waveform._timing.test_precision ‑ test___different_value___equality___not_equal[lhs0-rhs0]
tests.unit.waveform._timing.test_precision ‑ test___different_value___equality___not_equal[lhs1-rhs1]
…
tests.unit.waveform._scaling.test_linear ‑ test___different_value___equality___not_equal[left0-right0]
tests.unit.waveform._scaling.test_linear ‑ test___different_value___equality___not_equal[left1-right1]
tests.unit.waveform._scaling.test_linear ‑ test___different_value___equality___not_equal[left2-right2]
tests.unit.waveform._scaling.test_linear ‑ test___different_value___equality___not_equal[left3-right3]
tests.unit.waveform._scaling.test_linear ‑ test___different_value___equality___not_equal[left4-right4]
tests.unit.waveform._scaling.test_linear ‑ test___different_value___equality___not_equal[left5-right5]
tests.unit.waveform._scaling.test_linear ‑ test___same_value___equality___equal[left0-right0]
tests.unit.waveform._scaling.test_linear ‑ test___same_value___equality___equal[left1-right1]
tests.unit.waveform._scaling.test_linear ‑ test___scale_mode___copy___makes_shallow_copy
tests.unit.waveform._scaling.test_linear ‑ test___scale_mode___deepcopy___makes_deep_copy
…

♻️ This comment has been updated with latest results.

@bkeryan bkeryan force-pushed the users/bkeryan/waveform-copy-pickle branch from 7b000c2 to 985ba65 Compare April 30, 2025 18:45
@bkeryan bkeryan merged commit 67df337 into main Apr 30, 2025
14 checks passed
@bkeryan bkeryan deleted the users/bkeryan/waveform-copy-pickle branch April 30, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants