generated from ni/github-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 3
waveform: Add support for complex waveforms #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 10 files ± 0 10 suites ±0 30s ⏱️ +3s Results for commit eaa1342. ± Comparison against base commit b20757f. This pull request removes 1 and adds 42 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
bkeryan
commented
May 8, 2025
bkeryan
commented
May 8, 2025
bkeryan
commented
May 8, 2025
f0c5d13 to
8cf6863
Compare
csjall
approved these changes
May 9, 2025
bkeryan
commented
May 9, 2025
bkeryan
commented
May 9, 2025
csjall
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Create the
ComplexWaveformclass to support complex-number waveforms:AnalogWaveforminto an abstract base class,NumericWaveform(as opposed toDigitalWaveform)_TRaw_coNumericWaveform,_TScaled_co. ForAnalogWaveform,_TScaled_co=np.float64and forComplexWaveform,_TScaled_co=np.complex128.ComplexInt32DTypeconversion.Why should this Pull Request be merged?
Closes AB#3066698 - Define Python complex waveform data types
What testing has been done?
Ran
poetry run nps lint,mypy,pytest -v