Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented May 10, 2025

What does this Pull Request accomplish?

Enable type checking with Microsoft's type checker, Pyright, in addition to Mypy.

Why should this Pull Request be merged?

We should use both type checkers:

  • Mypy is the original Python type checker and is written in Python. It is more widely used by NI's Python projects and I think it's more widely used by Python projects in general.
  • Pyright is Microsoft's Python type checker and is written in TypeScript. It is integrated into the VS Code Pylance extension. Type checking with Pyright ensures that users will see the correct inferred types in VS Code.

What testing has been done?

Ran poetry run mypy and poetry run pyright locally.

@bkeryan bkeryan requested a review from csjall as a code owner May 10, 2025 00:49
@github-actions
Copy link
Contributor

Test Results

   10 files  ±0     10 suites  ±0   30s ⏱️ ±0s
  573 tests ±0    573 ✅ ±0  0 💤 ±0  0 ❌ ±0 
5 730 runs  ±0  5 730 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3eb9993. ± Comparison against base commit 13cbe86.

@bkeryan bkeryan merged commit d7af0b7 into main May 12, 2025
14 checks passed
@bkeryan bkeryan deleted the users/bkeryan/pyright branch May 12, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants