waveform: Add timing #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bkeryan
commented
Apr 18, 2025
bkeryan
commented
Apr 21, 2025
csjall
requested changes
Apr 21, 2025
bkeryan
commented
Apr 22, 2025
csjall
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add the
nitypes.waveform.Timingandnitypes.waveform.PrecisionTimingclasses.Add time conversion functions, with support for
datetimeandhightime.Add the
AnalogWaveform.timingandAnalogWaveform.precision_timingproperties.Why should this Pull Request be merged?
Implements AB#3082108: Add waveform timing
Partially implements AB#3068980: Irregular timing support
What testing has been done?
Ran nps, mypy, and pytest locally with Python 3.11.9.