generated from ni/github-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 3
waveform: Implement scaling #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bkeryan
commented
Apr 24, 2025
csjall
reviewed
Apr 24, 2025
csjall
approved these changes
Apr 24, 2025
bkeryan
commented
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add scale mode types:
ScaleMode: base class with a private_transform_datamethodNoneScaleMode: implementation that doesn't scale anythingNO_SCALING: singleton instance ofNoneScaleModeLinearScaleMode: implementation that scales linearlyAdd
AnalogWaveformmembers:scale_mode: get/set the scale modeget_raw_data: get a subset of the raw dataget_scaled_data: get a subset of the scaled data and/or scale to float32Add
_utils.arg_to_floatand reworkarg_to_intslightly. The biggest change is that args are required by default and optional if you specifydefault_value.Change "Provided value:" error messages to use repr.
Why should this Pull Request be merged?
Closes AB#3082118 - Add waveform scaling
What testing has been done?
Ran new unit tests