-
Notifications
You must be signed in to change notification settings - Fork 1.3k
back-port of texture-padding feature from GLES2 branch #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tom-braun
wants to merge
43
commits into
nicolasgramlich:GLES2
Choose a base branch
from
tom-braun:backport.texture-padding
base: GLES2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
back-port of texture-padding feature from GLES2 branch #188
tom-braun
wants to merge
43
commits into
nicolasgramlich:GLES2
from
tom-braun:backport.texture-padding
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odifier, instead of the longest.
…n the particle expires.
Also reduced memory allocations when loading PVRTextures and PVRGZTextures.
1043:a5cc28c9cdbftipGLES2Nicolas Gramlich2011-08-16 17:30Renamed clone to deepCopy, because Eclipse was not treating as an error, which it actually should be.
…nager. (Thx to Leandro De Brasi)
… scene to surface coordinates.
… not compiling into the jar.
Allow diagonals in Direction class.
Owner
|
Not mergable. Also are you trying to backport a feature from GLES2 to master? (Even though you are filing this PR against GLES2 and not master.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to get rid of bleeding textures when using the BlackPawnTextureBuilder I back-ported the padding code from the GLES2 branch.
The changes are straight forward. i just copied the corresponding code from the GLES2 branch to master. I took care to neither brake coding-style nor compatibility with existing code. I tested the code by introducing it to my app. This required absolutely no changes to my app's code. To make use of the padding feature however, one needs to use the new constructor of BlackPawnTextureBuilder providing it a border-spacing and padding value.