implement registering and sending custom notifications to lightningd #8
+85
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisguida
force-pushed
the
feat/cln-plugin-send-notifs
branch
from
58bc8be to
99f1488
Compare
chrisguida
force-pushed
the
feat/cln-plugin-send-notifs
branch
from
566c630 to
9675463
Compare
niftynei
force-pushed
the
nifty/onchain_notif
branch
from
9c035ab to
44c5b52
Compare
niftynei
pushed a commit
that referenced
this pull request
May 11, 2023
pubkey_from_hexstr() was failing, which we didn't notice because we
weren't checking the return value. The problem was that we were passing
it a strlen that was half the actual length.
Relevant error:
[libsecp256k1] illegal argument: !secp256k1_fe_is_zero(&ge->x)
==417723== ERROR: libFuzzer: deadly signal
#7 0x7f5deaacc7fb in abort
#8 0x51b0b0 in secp256k1_default_illegal_callback_fn secp256k1.c
#9 0x51bd8e in secp256k1_ec_pubkey_serialize
ElementsProject#10 0x4e235b in pubkey_to_der bitcoin/pubkey.c:29:7
ElementsProject#11 0x4e2941 in pubkey_cmp bitcoin/pubkey.c:89:2
ElementsProject#12 0x4e333d in bitcoin_redeem_2of2 bitcoin/script.c:144:6
ElementsProject#13 0x4f1396 in run tests/fuzz/fuzz-close_tx.c:78:19
chrisguida
force-pushed
the
feat/cln-plugin-send-notifs
branch
from
9675463 to
605be59
Compare
chrisguida
force-pushed
the
feat/cln-plugin-send-notifs
branch
from
605be59 to
d40a31d
Compare
chrisguida
force-pushed
the
feat/cln-plugin-send-notifs
branch
from
5077441 to
65e087e
Compare
… lightningd This functionality already exists in the Python framework; this feature enables it for Rust plugins as well. Changelog-Added: cln-plugin: Implement send_custom_notification to allow sending custom notifications to other plugins.
Also fix Makefile for rust plugin examples Also add in a missing assert in the test_plugin_start test
…example files themselves are changed and to rebuild all the examples when the dependencies are changed (`CLN_RPC_SOURCES`).
also eliminate a rust warning
chrisguida
force-pushed
the
feat/cln-plugin-send-notifs
branch
from
65e087e to
4ac5354
Compare
niftynei
force-pushed
the
nifty/onchain_notif
branch
from
44c5b52 to
37ad798
Compare
niftynei
force-pushed
the
nifty/onchain_notif
branch
from
37ad798 to
765bf3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.