fixes #20285; prevent oid time overflow at year 2038 #20338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reproduce the issue by setting the date on my computer to year 2038. |
|
Is it possible to add a test for this? |
|
I guess not too easy, at least we probably can get one at openSUSE :) |
Closed
Varriount
reviewed
Sep 15, 2022
|
Can we use the date command to test it? edit: lol, the last commit says it was made on Sep 12, 2038 |
|
I'm ok with either:
|
|
I say, please increase the underlying integer size to 64 bits. |
|
Sure |
|
Once again, I set the system date to 2038 and there is no problem. |
|
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
metagn
reviewed
Sep 22, 2022
ringabout
added a commit
that referenced
this pull request
Sep 22, 2022
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…g#20338) * Revert "fixes nim-lang#20285; prevent oid time overflow at year 2038" This reverts commit dfcdb6e. * increase time to 64 bits and clean up * add testcase * inline consts * add a changelog * fixes nim-lang#20285; prevent oid time overflow at year 2038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20285
ref py-bson/bson#117