Skip to content

Suppress temporary libc deprecations #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2020
Merged

Suppress temporary libc deprecations #1332

merged 2 commits into from
Nov 16, 2020

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Nov 15, 2020

See individual commits.

This PR is an alternative to #1329.

@asomers

@tamird
Suppress af_alg_iv "deprecation"
328530f 
See rust-lang/libc#1501 in which this type's
trait implementations are being removed; the change is being announced
via this deprecation.
@tamird
Suppress time_t musl "deprecation"
b373f2f 
See rust-lang/libc#1848 in which this type is
changing from i32 to i64; the change is being announced via this
deprecation.
asomers
asomers approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 16, 2020
@bors @tamird
Merge #1332
246bf3b 
1332: Suppress temporary libc deprecations r=asomers a=tamird

See individual commits.

This PR is an alternative to #1329.

@asomers 

Co-authored-by: Tamir Duberstein <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 16, 2020

Build failed:

@asomers
Copy link
Member

asomers commented Nov 16, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 16, 2020

Build succeeded:

@bors bors bot merged commit cde6e3e into nix-rust:master Nov 16, 2020
@tamird tamird deleted the libc-deprecations branch November 16, 2020 14:50
@tamird tamird mentioned this pull request Nov 16, 2020
Merged
@asomers asomers added this to the 0.19.1 milestone Nov 22, 2020
@asomers asomers mentioned this pull request Nov 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tamird @asomers