Skip to content

Improve test #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2016
Merged

Improve test #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54ee126
Improvements to skip "docs" and other non-docker directories
chorrell Sep 29, 2016
1b99bb9
Better approach to establishing variants
chorrell Sep 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions test-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ fi
versions=( "${versions[@]%/}" )

for version in "${versions[@]}"; do
if [[ "$version" == "docs" ]]; then
continue
fi
# Skip "docs" and other non-docker directories
[ -f "$version/Dockerfile" ] || continue

tag=$(cat $version/Dockerfile | grep "ENV NODE_VERSION" | cut -d' ' -f3)

Expand All @@ -47,9 +46,12 @@ for version in "${versions[@]}"; do
info "Test of $tag succeeded."
fi

variants=$(ls -d $version/*/ | awk -F"/" '{print $2}')
variants=$(echo $version/*/ | xargs -n1 basename)

for variant in $variants; do
# Skip non-docker directories
[ -f "$version/$variant/Dockerfile" ] || continue

info "Building $tag-$variant variant..."
docker build -t node:$tag-$variant $version/$variant

Expand Down