lib: expose global ErrorEvent #58920

Richienb · 2025-07-01T15:34:08Z

nodejs-github-bot · 2025-07-01T15:34:13Z

Review requested:

@nodejs/startup
@nodejs/web-standards

codecov · 2025-07-01T16:23:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (049664b) to head (4edeb85).
⚠️ Report is 212 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58920      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.01%     
==========================================
  Files         645      645              
  Lines      189130   189130              
  Branches    37094    37093       -1     
==========================================
- Hits       170339   170321      -18     
- Misses      11511    11516       +5     
- Partials     7280     7293      +13

Files with missing lines	Coverage Δ
...internal/bootstrap/web/exposed-window-or-worker.js	`93.79% <100.00%> (ø)`

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-07-01T20:43:05Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @panva.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot · 2025-07-02T00:38:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67782/

panva · 2025-07-02T08:13:13Z

cc @nodejs/tsc for semver-major PRs that contain breaking changes and should be released in the next major version.

panva · 2025-07-02T08:14:42Z

@KhafraDev Is the class is tested in https://github.com/nodejs/undici inclusive all its related WPTs?

Are there ErrorEvent WPTs we could enable in https://github.com/nodejs/node?

panva

Some form of test coverage should be present here.

doc/api/globals.md

KhafraDev · 2025-07-02T18:31:00Z

@KhafraDev Is the class is tested in https://github.com/nodejs/undici inclusive all its related WPTs?

Are there ErrorEvent WPTs we could enable in https://github.com/nodejs/node?

It is tested, but all of the WPTs iirc were html files, so I adapted them to run in our own test suite. There isn't anything node needs to enable. It should be safe to assume that, similar to everything else from undici, it follows the spec even closer than pretty much anything in node core.

https://github.com/nodejs/undici/blob/main/test/websocket/events.js

doc/api/globals.md

tools/doc/type-parser.mjs

aduh95 · 2025-07-06T08:44:17Z

Can you rebase to remove the merge commit please?

Richienb · 2025-07-12T10:31:37Z

Can we get a re-un of the ci?
Previous run got cancelled because of billing reasons.

gurgunday

lgtm

Co-authored-by: Antoine du Hamel <[email protected]>

Richienb · 2025-07-19T13:08:59Z

I think this PR is ready for merge?

nodejs-github-bot · 2025-07-22T22:42:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68136/

nodejs-github-bot · 2025-08-14T23:39:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68642/

nodejs-github-bot · 2025-08-15T15:04:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68657/

nodejs-github-bot · 2025-08-16T20:13:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68674/

KhafraDev · 2025-08-16T20:15:13Z

Another day, another try

nodejs-github-bot · 2025-08-17T22:17:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68686/

nodejs-github-bot · 2025-08-18T06:32:26Z

Commit Queue failed

- Loading data for nodejs/node/pull/58920
✔  Done loading data for nodejs/node/pull/58920
----------------------------------- PR info ------------------------------------
Title      lib: expose global ErrorEvent (#58920)
Author     Richie Bendall <[email protected]> (@Richienb)
Branch     Richienb:expose-errorevent -> nodejs:main
Labels     semver-major, lib / src, notable-change, author ready, needs-ci, commit-queue-squash
Commits    3
 - lib: expose global ErrorEvent
 - Update type-parser.mjs
 - Update tools/doc/type-parser.mjs
Committers 1
 - Richie Bendall <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58920
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58920
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 01 Jul 2025 15:34:08 GMT
   ✔  Approvals: 4
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/58920#pullrequestreview-2976453301
   ✔  - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/58920#pullrequestreview-2976691720
   ✔  - Jason Zhang (@jazelly): https://github.com/nodejs/node/pull/58920#pullrequestreview-3012989485
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/58920#pullrequestreview-2991105194
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-08-17T22:17:37Z: https://ci.nodejs.org/job/node-test-pull-request/68686/
- Querying data for job/node-test-pull-request/68686/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/17032906904

nodejs-github-bot · 2025-08-18T08:14:56Z

Landed in 663554a

PR-URL: nodejs#58920 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 1, 2025

panva added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 1, 2025

himself65 approved these changes Jul 1, 2025

View reviewed changes

KhafraDev approved these changes Jul 1, 2025

View reviewed changes

panva added the notable-change PRs with changes that should be highlighted in changelogs. label Jul 1, 2025

jazelly approved these changes Jul 2, 2025

View reviewed changes

himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2025

panva reviewed Jul 2, 2025

View reviewed changes

aduh95 reviewed Jul 2, 2025

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

Richienb requested a review from aduh95 July 3, 2025 09:50

aduh95 approved these changes Jul 6, 2025

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

tools/doc/type-parser.mjs Outdated Show resolved Hide resolved

gurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2025

gurgunday approved these changes Jul 12, 2025

View reviewed changes

Richienb and others added 3 commits July 12, 2025 23:15

lib: expose global ErrorEvent

7a8144c

Update type-parser.mjs

a76297b

Update tools/doc/type-parser.mjs

4edeb85

Co-authored-by: Antoine du Hamel <[email protected]>

Richienb force-pushed the expose-errorevent branch from 9fa8a55 to 4edeb85 Compare July 12, 2025 11:17

jazelly approved these changes Jul 12, 2025

View reviewed changes

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2025

KhafraDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 18, 2025

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 18, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 18, 2025

aduh95 requested a review from panva August 18, 2025 08:01

panva approved these changes Aug 18, 2025

View reviewed changes

panva added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 18, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 18, 2025

nodejs-github-bot merged commit 663554a into nodejs:main Aug 18, 2025
72 checks passed

Uh oh!

lib: expose global ErrorEvent #58920

lib: expose global ErrorEvent #58920

Uh oh!

Conversation

Richienb commented Jul 1, 2025

Uh oh!

nodejs-github-bot commented Jul 1, 2025

Uh oh!

codecov bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

nodejs-github-bot commented Jul 2, 2025

Uh oh!

panva commented Jul 2, 2025

Uh oh!

panva commented Jul 2, 2025

Uh oh!

panva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KhafraDev commented Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

aduh95 commented Jul 6, 2025

Uh oh!

Richienb commented Jul 12, 2025

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

Richienb commented Jul 19, 2025

Uh oh!

nodejs-github-bot commented Jul 22, 2025

Uh oh!

nodejs-github-bot commented Aug 14, 2025

Uh oh!

nodejs-github-bot commented Aug 15, 2025

Uh oh!

nodejs-github-bot commented Aug 16, 2025

Uh oh!

KhafraDev commented Aug 16, 2025

Uh oh!

nodejs-github-bot commented Aug 17, 2025

Uh oh!

nodejs-github-bot commented Aug 18, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 18, 2025

Uh oh!

Uh oh!

codecov bot commented Jul 1, 2025 •

edited

Loading