Skip to content

Conversation

codebytere
Copy link
Member

Modify a few more crypto tests to work with BoringSSL as well as OpenSSL.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 11, 2025
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (0d128e3) to head (0cd7531).
⚠️ Report is 386 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59030      +/-   ##
==========================================
- Coverage   90.08%   90.05%   -0.03%     
==========================================
  Files         645      645              
  Lines      189128   189153      +25     
  Branches    37088    37093       +5     
==========================================
- Hits       170378   170344      -34     
- Misses      11470    11530      +60     
+ Partials     7280     7279       -1     

see 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebytere codebytere requested a review from jasnell July 17, 2025 09:19
@codebytere codebytere force-pushed the few-more-boringssl branch from 12cbfbb to 0cd7531 Compare July 17, 2025 09:22
@codebytere codebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2025
Copy link
Contributor

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/16355431450

@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jul 17, 2025
@codebytere
Copy link
Member Author

@jasnell @tniessen would you be willing to give this a review?

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2025
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

@codebytere It looks like the OpenSSL 1.1.1 CI breaks with these changes,
e.g. https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_openssl111_x64/52674/

14:23:02 not ok 863 parallel/test-crypto-async-sign-verify
14:23:02   ---
14:23:02   duration_ms: 265.54800
14:23:02   severity: fail
14:23:02   exitcode: 1
14:23:02   stack: |-
14:23:02     node:assert:858
14:23:02         throw err;
14:23:02         ^
14:23:02     
14:23:02     AssertionError [ERR_ASSERTION]: The input did not match the regular expression /operation[\s_]not[\s_]supported[\s_]for[\s_]this[\s_]keytype/i. Input:
14:23:02     
14:23:02     'error:060A109E:digital envelope routines:do_sigver_init:no default digest'
14:23:02     
14:23:02         at SignJob.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-crypto-async-sign-verify.js:163:12)
14:23:02         at SignJob.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/index.js:472:15)
14:23:02         at job.ondone (node:internal/crypto/sig:312:23) {
14:23:02       generatedMessage: true,
14:23:02       code: 'ERR_ASSERTION',
14:23:02       actual: 'error:060A109E:digital envelope routines:do_sigver_init:no default digest',
14:23:02       expected: /operation[\s_]not[\s_]supported[\s_]for[\s_]this[\s_]keytype/i,
14:23:02       operator: 'match',
14:23:02       diff: 'simple'
14:23:02     }
14:23:03     
14:23:03     Node.js v25.0.0-pre
14:23:03   ...

@codebytere
Copy link
Member Author

@richardlau ah thanks - i'll get that fixed up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants