-
-
Notifications
You must be signed in to change notification settings - Fork 33k
test,crypto: handle a few more BoringSSL tests #59030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59030 +/- ##
==========================================
- Coverage 90.08% 90.05% -0.03%
==========================================
Files 645 645
Lines 189128 189153 +25
Branches 37088 37093 +5
==========================================
- Hits 170378 170344 -34
- Misses 11470 11530 +60
+ Partials 7280 7279 -1 🚀 New features to boost your workflow:
|
12cbfbb
to
0cd7531
Compare
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/16355431450 |
@codebytere It looks like the OpenSSL 1.1.1 CI breaks with these changes,
|
@richardlau ah thanks - i'll get that fixed up! |
Modify a few more crypto tests to work with BoringSSL as well as OpenSSL.