Test/bigint negative exponent message #59540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set transparent background for menu in both light and dark modes - Adjusted text colors for better contrast - Light mode: rgba(0, 0, 0, 0.1) background with dark text - Dark mode: rgba(255, 255, 255, 0.1) background with white text
doc: make documentation menu background transparent
Add a test documenting expected error message for BigInt exponentiation with a negative exponent. Currently skipped due to a V8 regression causing “undefined must be positive” instead of “Exponent must be positive”. Refs: chromium#439515479 Refs: nodejs#59521
|
Review requested:
|
|
Please revert the unrelated changes |
reverted |
|
There's no need to test for trivial upstream behaviours. V8 has its own test suite, which gets run by Node.js CI anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.